Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge mac mul chip #6

Closed
wants to merge 2 commits into from
Closed

feat: merge mac mul chip #6

wants to merge 2 commits into from

Conversation

lightsing
Copy link
Member

@lightsing lightsing commented Jun 18, 2024 •
edited
Loading

  • poseidon: 8.2k -> 11.3k cycles (+3.1k)
  • Before:
    • Bn254ScalarMulChip 370 cols
    • Bn254ScalarMacChip 648 cols
  • After:
    • Bn254ScalarMacChip Cols 917 cols (-101)

@lightsing lightsing changed the title feat: merge Mac mul chip feat: merge mac mul chip Jun 18, 2024
@kunxian-xia
Copy link
Collaborator

can you describe the number of columns that saved by generalizing mac chip (ret = a*b + ret * c) to make mul as a special case?

@kunxian-xia
Copy link
Collaborator

We won't merge this pr as it only saves about 10% columns while increasing the number of cycles by about 40%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunxian-xia kunxian-xia kunxian-xia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lightsing @kunxian-xia