Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coordinator): get empty task #1406

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jun 28, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Jun 28, 2024
@colinlyguo colinlyguo merged commit 5f31d28 into develop Jun 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.31%. Comparing base (eada1d0) to head (83c4f59).
Report is 1 commits behind head on develop.

Current head 83c4f59 differs from pull request most recent head bcf4c6f

Please upload reports for the commit bcf4c6f to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1406   +/-   ##
========================================
  Coverage    54.31%   54.31%           
========================================
  Files          156      156           
  Lines        11918    11918           
========================================
  Hits          6473     6473           
  Misses        4950     4950           
  Partials       495      495           
Flag Coverage Δ
coordinator 19.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo deleted the fix-coordinator-get-empty-task branch June 28, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants