Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove contract, l2geth from monorepo #1403

Closed
wants to merge 2 commits into from
Closed

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Jun 27, 2024

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

remove contract, l2geth from monorepo

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@georgehao georgehao changed the title remove submoudle components remove contract, l2geth from monorepo Jun 27, 2024
@georgehao georgehao requested a review from zimpha June 27, 2024 16:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.31%. Comparing base (eada1d0) to head (ca31b96).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1403   +/-   ##
========================================
  Coverage    54.31%   54.31%           
========================================
  Files          156      156           
  Lines        11918    11918           
========================================
  Hits          6473     6473           
  Misses        4950     4950           
  Partials       495      495           
Flag Coverage Δ
bridge-history-api 72.50% <ø> (ø)
database 42.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao
Copy link
Member Author

scroll monorepo some unit test reply on contract. can't delete it. close this pr

@georgehao georgehao closed this Jun 27, 2024
@georgehao
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants