-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use submodules for contracts #1396
Conversation
How about don't put submoudle to monorepo, also remove |
Sounds good to me. I'm fine with removing it. But as I recall a few integration tests are using it. (Maybe it's fine to remove those.) |
agreed. |
ok |
Reopen this PR, we will still use codec implementations to check the workflow (mainly hash calculation) in infra components. These hash checks are minimum requirements for merging new features, it can at least align contract and infra components to some extent. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1396 +/- ##
========================================
Coverage 54.31% 54.31%
========================================
Files 156 156
Lines 11918 11918
========================================
Hits 6473 6473
Misses 4950 4950
Partials 495 495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose or design rationale of this PR
This PR remove
contracts
directory and addscroll-contracts
repo ad submodule.Q: Why not reuse
contracts
directory for the submodule?A: It contains submodules before, changing it to another submodule would lead some problems in git.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?