Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): add unit test for circuits e2e test (used in test_zkp project) #1379

Merged
merged 14 commits into from
Jun 18, 2024

Conversation

amoylan2
Copy link
Member

Purpose or design rationale of this PR

feat(prover): add unit test for circuits e2e test (used in test_zkp project)

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@amoylan2
Copy link
Member Author

Currently, I'm testing this in this machine | idc-us-node-19 | 192.168.1.169
The working directory is /home/ubuntu/mengran/prover_unittests
And just running ./start.sh to see the test result.

The test failed with an error Floating point exception (core dumped). The full log is in test.log
I have talked to @lispc , who will check it next week.

@georgehao
Copy link
Member

Anyhow, I think you should add the integration test which you have deleted associated golang prover

@lispc
Copy link
Contributor

lispc commented Jun 17, 2024

will check this afternoon

lispc
lispc previously approved these changes Jun 18, 2024
@amoylan2 amoylan2 merged commit 738c857 into develop Jun 18, 2024
6 checks passed
@amoylan2 amoylan2 deleted the feat/prover_e2e_test branch June 18, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants