add fixme

scroll-tech · Jul 1, 2024 · e24ce85 · e24ce85
1 parent 187d5c6
commit e24ce85
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/common/types/message/message.go b/common/types/message/message.go
@@ -52,11 +52,12 @@ type ChunkTaskDetail struct {
 
 // BatchTaskDetail is a type containing BatchTask detail.
 type BatchTaskDetail struct {
-	ChunkInfos      []*ChunkInfo     `json:"chunk_infos"`
-	ChunkProofs     []*ChunkProof    `json:"chunk_proofs"`
-	ParentStateRoot common.Hash      `json:"parent_state_root"`
-	ParentBatchHash common.Hash      `json:"parent_batch_hash"`
-	BatchHeader     *codecv3.DABatch `json:"batch_header"`
+	ChunkInfos      []*ChunkInfo  `json:"chunk_infos"`
+	ChunkProofs     []*ChunkProof `json:"chunk_proofs"`
+	ParentStateRoot common.Hash   `json:"parent_state_root"`
+	ParentBatchHash common.Hash   `json:"parent_batch_hash"`
+	// FIXME: this structure does not support json marshal/unmarshal well.
+	BatchHeader *codecv3.DABatch `json:"batch_header"`
 }
 
 // BundleTaskDetail consists of all the information required to describe the task to generate a proof for a bundle of batches.

diff --git a/coordinator/internal/logic/provertask/batch_prover_task.go b/coordinator/internal/logic/provertask/batch_prover_task.go
@@ -226,6 +226,7 @@ func (bp *BatchProverTask) formatProverTask(ctx context.Context, task *orm.Prove
 		if err != nil {
 			return nil, fmt.Errorf("failed to decode batch header, taskID:%s err:%w", task.TaskID, err)
 		}
+		// FIXME: this structure does not support json marshal/unmarshal well.
 		taskDetail.BatchHeader = batchHeader
 	}