Fix ci login (#238)

* fix ci-login by adding permissions to workflow * Add registry permissions * test * fix helm registry login * fix the remaining issues * test without the env variable HELM_GITHUB_PASSWORD * remove the HELM_GITHUB_PASSWORD everywhere * test * remove permissions on workflow * test * revert scroll-sdk bump version
scroll-tech · Nov 21, 2024 · 30df052 · 30df052
1 parent 28badfb
commit 30df052
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 20 deletions.
diff --git a/.github/workflows/lint-test-charts.yml b/.github/workflows/lint-test-charts.yml
@@ -34,8 +34,6 @@ jobs:
       - name: Helm registry login
         run: |
           helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
 
       - name: Run chart-testing (list-changed)
         id: list-changed

diff --git a/.github/workflows/publish-chart.yaml b/.github/workflows/publish-chart.yaml
@@ -33,8 +33,6 @@ jobs:
       - name: Helm registry login
         run: |
           helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
 
       #  List chart change except scroll-sdk
       - name: Run chart-testing (list-changed)
@@ -73,8 +71,6 @@ jobs:
       - name: Helm registry login
         run: |
           helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
 
         # We filter here the scroll-sdk chart
       - name: Push chart to ghcr
@@ -134,8 +130,6 @@ jobs:
       - name: Helm registry login
         run: |
           helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
 
       #  List scroll-sdk chart if it has changed
       - name: Run chart-testing (list-changed)
@@ -174,8 +168,6 @@ jobs:
       - name: Helm registry login
         run: |
           helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
 
       - name: Push chart to ghcr
         if: steps.filter.outputs.addedOrModified == 'true'

diff --git a/.github/workflows/publish-dev-chart.yaml b/.github/workflows/publish-dev-chart.yaml
@@ -35,8 +35,6 @@ jobs:
       - name: Helm registry login
         run: |
           helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
 
       #  List chart change except scroll-sdk
       - name: Run chart-testing (list-changed)
@@ -74,9 +72,7 @@ jobs:
 
       - name: Helm registry login
         run: |
-          helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.HELM_GITHUB_PASSWORD }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
+          helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
 
         # We filter here the scroll-sdk chart
       - name: Push chart to ghcr
@@ -136,8 +132,6 @@ jobs:
       - name: Helm registry login
         run: |
           helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
 
       #  List scroll-sdk chart if it has changed
       - name: Run chart-testing (list-changed)
@@ -175,9 +169,7 @@ jobs:
 
       - name: Helm registry login
         run: |
-          helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.HELM_GITHUB_PASSWORD }}
-        env:
-          HELM_GITHUB_PASSWORD: "${{ secrets.HELM_GITHUB_PASSWORD }}"
+          helm registry login ghcr.io/scroll-tech/helm/scroll-sdk --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }}
 
       - name: Replace helm registry by helm/dev
         run: |