Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add es and zh translation to the feedback form #329

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

brolag
Copy link

@brolag brolag commented Sep 3, 2024

Closing issues

closes #202 202

...

Description

Adds feedback form translations to es and zh.

image image

...

Changes

  • Import i18next to the feedback component.
  • Created a new translation grupo into rightSidebar for es and zh
  • Replaced the hardcoded texts with the t function.

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 1c07f98
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/66fe0fdd51603300086ba094
😎 Deploy Preview https://deploy-preview-329.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Turupawn
Copy link
Member

Turupawn commented Sep 3, 2024

Spanish translation lgtm 👍

Good to see known faces contributing 😄

@emilyJLin95
Copy link
Contributor

@ChuhanJin can you take a look at the Chinese translation?

Also, can we check on why the deployment is failing @brolag

@brolag
Copy link
Author

brolag commented Sep 5, 2024

@emilyJLin95

I'm getting this error from the develop branch as well. Seems to be related to the @astro/preact package. It seem to be unrelated but I'll try to fix it.

image

 generating static routes
09:59:47 ▶ src/pages/404.astro
09:59:47   └─ /404.htmlCannot convert undefined or null to object
  Stack trace:
    at Function.keys (<anonymous>)
    at Object.renderToStaticMarkup$1 (file:///~/scroll/scroll-documentation/dist/renderers.mjs:130:3)
    at async renderComponent (file:///~/Sites/scroll/scroll-documentation/dist/chunks/astro/server_DiIDKlgx.mjs:1515:10)
    ```
    

@brolag
Copy link
Author

brolag commented Oct 3, 2024

Hi @emilyJLin95 this should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Feedback form translation
3 participants