Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable bench ci steps on scroll branch #8

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Thegaram
Copy link

@Thegaram Thegaram commented Oct 3, 2024

This action is failing with

    Finished `profiling` profile [optimized + debuginfo] target(s) in 1m 58s
     Running benches/iai.rs (target/profiling/deps/iai-068d5ba708ef06ee)
iai_callgrind_runner: Error: Failed to decode configuration
error: bench failed, to rerun pass `-p reth-db --bench iai`

Caused by:
  process didn't exit successfully: `/home/runner/work/reth/reth/target/profiling/deps/iai-068d5ba708ef06ee --save-baseline=base --bench` (exit status: 1)
Error: Process completed with exit code 1.

in the "save baseline" step.

I traced this error back to here and here, but I have not been able to fix it yet. Since we probably won't change this db serialization par, it is fine to disable this action.

@Thegaram Thegaram merged commit 7f54273 into scroll Oct 3, 2024
38 checks passed
@Thegaram Thegaram deleted the feat-disable-bench-on-scroll-branch branch October 3, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant