Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync halo2 lib 0.4.0: scroll diffs #24

Open
wants to merge 9 commits into
base: release-0.4.0-rc-base
Choose a base branch
from
Open

Sync halo2 lib 0.4.0: scroll diffs #24

wants to merge 9 commits into from

Conversation

lispc
Copy link

@lispc lispc commented Dec 1, 2023 •
edited
Loading

old scroll features (git diff main develop):

(some are not needed any more? But at least new APIs are needed?)

  • fixed mul -1 bug
  • disable Karabina cyclotomic optimization
  • many audit fixes like divide_unsafe and ecdsa
  • new APIs like and_many and is_less_than_p
  • fp_chip assert equal bug

@lispc lispc changed the base branch from release-0.4.0-rc to release-0.4.0-rc-base December 1, 2023 02:34
@lispc
Copy link
Author

lispc commented Dec 1, 2023

seems good..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lispc @zhenfeizhang