refactor: use new da codec interfaces in syncing from L1 #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eum into refactor/2-use-new-da-codec-interfaces
…oll-tech/go-ethereum into refactor/2-use-new-da-codec-interfaces
colinlyguo
reviewed
Oct 20, 2024
colinlyguo
changed the title
colinlyguo
approved these changes
Oct 21, 2024
colinlyguo
approved these changes
Oct 21, 2024
colinlyguo
merged commit 8abbc11
into
refactor/use-new-da-codec-interfaces
4 of 5 checks passed
colinlyguo
added a commit
that referenced
this pull request
Oct 21, 2024
* refactor: use new da-codec interfaces * go mod tidy * tweak * add a tweak * tweak logs * update da-codec commit * refactor: use new da codec interfaces in syncing from L1 (#1078) * use new da-codec interface in syncing from l1 * delete unused * nit * uncomment * typo --------- Co-authored-by: colinlyguo <[email protected]> * update da-codec * use IsL1MessageSkipped in da-codec repo * use canonical version * address AI's comments: add nil checks --------- Co-authored-by: Nazarii Denha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?