fix blob_client_list

scroll-tech · Aug 15, 2024 · 9e1769f · 9e1769f
1 parent 399dcfc
commit 9e1769f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/rollup/da_syncer/blob_client/blob_client_list.go b/rollup/da_syncer/blob_client/blob_client_list.go
@@ -30,7 +30,7 @@ func (c *BlobClientList) GetBlobByVersionedHash(ctx context.Context, versionedHa
 
 	for i := 0; i < len(c.list); i++ {
 		blob, err := c.list[c.nextPos()].GetBlobByVersionedHash(ctx, versionedHash)
-		if err != nil {
+		if err == nil {
 			return blob, nil
 		}
 

diff --git a/rollup/da_syncer/da/commitV1.go b/rollup/da_syncer/da/commitV1.go
@@ -59,6 +59,9 @@ func NewCommitBatchDAV1WithBlobDecodeFunc(ctx context.Context, db ethdb.Database
 	if err != nil {
 		return nil, fmt.Errorf("failed to fetch blob from blob client, err: %w", err)
 	}
+	if blob == nil {
+		return nil, fmt.Errorf("unexpected, blob == nil and err != nil, batch index: %d, versionedHash: %s, blobClient: %T", batchIndex, versionedHash.String(), blobClient)
+	}
 
 	// compute blob versioned hash and compare with one from tx
 	c, err := kzg4844.BlobToCommitment(blob)