Make cargo build work
#719
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
…n' into matthias/integration-test-are-busted
…ation-test-are-busted
.github/workflows/integration.yml
Outdated
| @@ -32,13 +32,6 @@ jobs: | |||
| timeout-minutes: 30 | |||
| runs-on: [self-hosted, Linux, X64] | |||
|
|
|||
| strategy: | |||
There was a problem hiding this comment.
Our strategy matrix only has one entry. So we might as well not bother.
There was a problem hiding this comment.
Extracted into #725
| key: integration-${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }} | ||
| - uses: dtolnay/rust-toolchain@nightly | ||
|
|
||
| - name: Run example | ||
| env: | ||
| RAYON_NUM_THREADS: 2 |
There was a problem hiding this comment.
This isn't read anywhere.
This was referenced Dec 10, 2024
matthiasgoergens
added a commit
that referenced
this pull request
Dec 12, 2024
Extracted from #719 for ease of review. Our strategy matrix only has one entry, so we might as well not use it. Also, using `riscv32im-unknown-none-elf` as the target anywhere actually fails. As an example you can try `TARGET=riscv32im-unknown-none-elf cargo make clippy` on current `master`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now a simple
cargo buildfails. So let's fix that.This PR also disentangles
ceno_rt, so that we can work on building guest programs much easier.Update: I extracted the remove of the target matrix into #725 for ease of review.