Feat/ecall nop #570
Merged
Feat/ecall nop #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
naure
added a commit
that referenced
this pull request
Nov 8, 2024
_Issue #359 and #567_ * The `DummyInstruction` implements all the communications of a step: state, fetch, registers, memory. But it does not verify calculations: any value can be written out. * Placeholder circuits for missing implementations, including unknown ecalls. * More precise register op assignment, see #570. --------- Co-authored-by: Aurélien Nicolas <[email protected]>
mcalancea
added a commit
that referenced
this pull request
Nov 13, 2024
commit dfc85dc Author: Mihai <[email protected]> Date: Wed Nov 13 15:30:17 2024 +0200 clean experimental code commit 618965a Merge: a21a628 82af85a Author: Mihai <[email protected]> Date: Wed Nov 13 15:27:20 2024 +0200 merge master commit a21a628 Author: Mihai <[email protected]> Date: Wed Nov 13 13:47:25 2024 +0200 add stats.rs commit deb0bd3 Author: Mihai <[email protected]> Date: Wed Nov 13 13:45:52 2024 +0200 stash commit c200f2f Author: Mihai <[email protected]> Date: Tue Nov 12 17:15:45 2024 +0200 stash commit fc45251 Author: Mihai <[email protected]> Date: Tue Nov 12 16:21:39 2024 +0200 stash commit e2408b3 Author: Mihai <[email protected]> Date: Tue Nov 12 16:02:37 2024 +0200 more stash commit 5cccc29 Author: Mihai <[email protected]> Date: Tue Nov 12 12:32:55 2024 +0200 stash commit 4129e52 Author: Mihai <[email protected]> Date: Tue Nov 12 10:32:28 2024 +0200 add ConstraintStats commit 82af85a Author: mcalancea <[email protected]> Date: Tue Nov 12 09:35:07 2024 +0200 Extend profiling using `tracing` (#572) Improve profiling efforts by: - refactoring tracing spans - addressing a pitfall regarding spawned threads - changing some subscriber configs commit 54c8114 Author: Matthias Görgens <[email protected]> Date: Tue Nov 12 07:34:18 2024 +0700 Remove some redundant `.into_iter()` (#581) Just a minor clean-up while I'm reading through our code. commit 85f8dd8 Author: Mihai <[email protected]> Date: Mon Nov 11 18:43:12 2024 +0200 stash commit 4acd8c9 Author: Matthias Görgens <[email protected]> Date: Mon Nov 11 16:28:43 2024 +0700 Remove unused file (#580) This finishes work done in #201 commit 311d79e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Nov 11 08:12:12 2024 +0000 Bump tempfile from 3.13.0 to 3.14.0 (#578) commit 0389112 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Nov 11 08:11:57 2024 +0000 Bump anyhow from 1.0.92 to 1.0.93 (#579) commit 853f1ba Author: Cyte Zhang <[email protected]> Date: Mon Nov 11 15:55:49 2024 +0800 Change BaseFold trim API to consume pp & truncate public parameters directly in `trim` (#248) Considering that BaseFold trim is almost always used only once in each program execution, consume the input public parameter instead of clone it to save memory. This API change also allows the `trim` function to directly truncate the input public parameters. commit 8e00028 Author: naure <[email protected]> Date: Fri Nov 8 14:32:07 2024 +0100 Dummy Circuit - Basic ECALL (#369) _Issue #359 and #567_ * The `DummyInstruction` implements all the communications of a step: state, fetch, registers, memory. But it does not verify calculations: any value can be written out. * Placeholder circuits for missing implementations, including unknown ecalls. * More precise register op assignment, see #570. --------- Co-authored-by: Aurélien Nicolas <[email protected]> commit a060e15 Author: Matthias Görgens <[email protected]> Date: Fri Nov 8 18:33:25 2024 +0800 Remove unimplmented and unused functions (#576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #369
This PR highlights the difference between regular instructions (I-type…), and ecalls as defined in
VMState::ecall(). It has to be precise regarding registers: the instruction encoding does not imply the actual operations.