Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Default for Expression<E> #370

Closed
wants to merge 2 commits into from
Closed

Implement Default for Expression<E> #370

wants to merge 2 commits into from

Conversation

matthiasgoergens
Copy link
Collaborator

@hero78119
Copy link
Collaborator

Cite from other comment and also comment here as memo #369 (comment)

We dont really need Default implementation of Expression because of its default behaviour differ case by case, therefore we rely on application side to define it. Blindly default might occur unexpected bug in some scenario. In other expression-based proving system, e.g. halo2 also follow the similar idea for no "default" impl on expression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasgoergens @hero78119