Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dex price source support #29

Merged
merged 2 commits into from
Dec 31, 2024
Merged

feat: add dex price source support #29

merged 2 commits into from
Dec 31, 2024

Conversation

mootz12
Copy link
Contributor

@mootz12 mootz12 commented Dec 19, 2024

No description provided.

README.md Outdated
@@ -27,6 +27,8 @@ docker run --restart always -d -v /path/on/host:/app/data script3/auctioneer-bot

The auctioneer bot requires access to a Soroban RPC server, and is fairly chatty. We recommend running an Soroban RPC server on the same host to avoid issues with rate limiting / usage. Please see the Stellar documentation for running a [Soroban RPC](https://developers.stellar.org/docs/data/rpc). We recommend running the [Soroban RPC as a docker container](https://developers.stellar.org/docs/data/rpc/admin-guide#docker-image). The Auctioneer bot itself is not very resource intensive, and should work fine alongside an RPC with the suggested hardware requirements for the Soroban RPC server.

The auctioneer bot also (optionally) uses Horizon to fetch prices from the DEX. If you use this, the bot keeps requests fairly quite (up to 1 request a minute per asset), so using a public Horizon endpoint sgould be OK. However, it is recommended to use a Horizon hosting solution to ensure uptime (e.g. Blockdaemon or Quicknode).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo quiet* and should*

Comment on lines 6 to 9
export interface PoolUserEst {
estimate: PositionsEstimate;
user: PoolUser;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being used somewhere?

@mootz12 mootz12 requested a review from Ryang-21 December 23, 2024 14:24
@mootz12 mootz12 merged commit 8e32f6f into main Dec 31, 2024
1 check passed
@mootz12 mootz12 deleted the add-dex-price-source branch December 31, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants