Position management #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryang-21
reviewed
Nov 14, 2024
| ['ASSET1', 100n], | ||
| ['ASSET3', 200n], | ||
| ]), | ||
| lot: new Map<string, bigint>([['ASSET1', 100n]]), |
There was a problem hiding this comment.
I think the lot should match something in profits same with the test below
| @@ -43,6 +43,8 @@ describe('validateAppConfig', () => { | |||
| keypair: Keypair.random().secret(), | |||
| minProfitPct: 1, | |||
| minHealthFactor: 1, | |||
| primaryAsset: 'asset', | |||
| minPrimaryCollateral: '100', | |||
There was a problem hiding this comment.
add tests for validating profit
package-lock.json
Outdated
| @@ -9,8 +9,8 @@ | |||
| "version": "0.0.0", | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@blend-capital/blend-sdk": "^2.0.3", | |||
| "@stellar/stellar-sdk": "^12.3.0", | |||
| "@blend-capital/blend-sdk": "2.1.1", | |||
Ryang-21
requested changes
Dec 3, 2024
src/auction.ts
Outdated
| } else { | ||
| throw new Error(`Failed to value bid asset: ${assetId}`); | ||
| } | ||
| } | ||
|
|
||
| return { effectiveCollateral, effectiveLiabilities, lotValue, bidValue }; | ||
| return { effectiveCollateral, effectiveLiabilities, repayableLiabilities, lotValue, bidValue }; |
There was a problem hiding this comment.
repayableLiabilities is no longer used
src/bidder_submitter.ts
Outdated
| const pool = await sorobanHelper.loadPool(); | ||
| const poolOracle = await sorobanHelper.loadPoolOracle(); | ||
| const filler_user = await sorobanHelper.loadUser(filler_pubkey); | ||
| const filler_balances = await sorobanHelper.loadBalances(filler_pubkey, filler_tokens); |
src/filler.ts
Outdated
Comment on lines
131
to
134
| if (isNative) { | ||
| tokenBalance = | ||
| tokenBalance > FixedMath.toFixed(50, 7) ? tokenBalance - FixedMath.toFixed(50, 7) : 0n; | ||
| } |
There was a problem hiding this comment.
This isn't necessary if getFillerAvailableBalance is used
Ryang-21
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.