Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error handling when interacting with rpc #23

Merged
merged 4 commits into from
Oct 3, 2024
Merged

feat: improve error handling when interacting with rpc #23

merged 4 commits into from
Oct 3, 2024

Conversation

mootz12
Copy link
Contributor

@mootz12 mootz12 commented Oct 2, 2024

Fixes #10

  • Remove auction deletion on drop
  • Add min retry timeout
  • Process all auctions in db on new block event even if one fails to load

Base automatically changed from safer-user-liquidations to main October 2, 2024 17:53
Ryang-21
Ryang-21 requested changes Oct 2, 2024
View reviewed changes
.github/workflows/tests.yml Show resolved Hide resolved
test/utils/submission_queue.test.ts Outdated Show resolved Hide resolved
test/utils/submission_queue.test.ts Outdated Show resolved Hide resolved
@mootz12 mootz12 merged commit 276f8e6 into main Oct 3, 2024
1 check passed
@mootz12 mootz12 deleted the better-error-handling branch October 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryang-21 Ryang-21 Ryang-21 approved these changes

@markuspluna markuspluna Awaiting requested review from markuspluna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue: Determine actions to take when oracle price fails to load
2 participants
@mootz12 @Ryang-21