Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a typo in readme.md #59

Closed

Conversation

OmarAI2003
Copy link
Contributor

This PR fixes a minor typo in the README.md file. I changed "an tools" to "tools".

- Updated file reading to use a context manager for better resource management.
- Added error handling for FileNotFoundError when accessing Localizable.xcstrings.
- Implement try-except block for JSONDecodeError to handle invalid JSON format.
- Refined language handling.
- Added directory existence check and creation to prevent errors.
Copy link

github-actions bot commented Oct 4, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and i18n rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@OmarAI2003 OmarAI2003 closed this Oct 4, 2024
@OmarAI2003 OmarAI2003 deleted the fixing-a-typo-in-readme.md branch October 4, 2024 18:00
@OmarAI2003 OmarAI2003 restored the fixing-a-typo-in-readme.md branch October 4, 2024 18:02
@OmarAI2003 OmarAI2003 deleted the fixing-a-typo-in-readme.md branch October 4, 2024 18:03
@OmarAI2003 OmarAI2003 restored the fixing-a-typo-in-readme.md branch October 4, 2024 18:03
@OmarAI2003 OmarAI2003 reopened this Oct 4, 2024
@OmarAI2003
Copy link
Contributor Author

I’m closing this PR because it unintentionally includes commits from another branch . I created a new branch directly from main for the typo fix and will open a new PR for it. Sorry for the confusion!

@OmarAI2003 OmarAI2003 closed this Oct 4, 2024
@OmarAI2003 OmarAI2003 deleted the fixing-a-typo-in-readme.md branch October 4, 2024 18:04
@andrewtavis
Copy link
Member

I thought this had been merged, or was that in a downstream project, @OmarAI2003?

@andrewtavis
Copy link
Member

We should do something with this here?

@OmarAI2003
Copy link
Contributor Author

No It was in another repo the Data repo

@andrewtavis
Copy link
Member

Just saw the comment above. All good!

@andrewtavis
Copy link
Member

Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants