Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib.rs and added few more punctuation marks #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KesharwaniArpita
Copy link

Contributor checklist


Description

This pull request enhances the allowed_keys function by adding support for a comprehensive set of punctuation marks and special characters. The function previously handled only a limited selection of punctuation, such as commas and semicolons. This update improves the coverage of punctuation, allowing the function to return characters like apostrophes, periods, exclamation marks, and more.

  1. Enhances text and command input functionality by ensuring that all common punctuation marks are recognized and processed.
  2. Ensures a more complete user experience when handling textual data, especially in cases requiring punctuation.

Related issue

Copy link

github-actions bot commented Oct 8, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Desktop rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Desktop repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Oct 9, 2024
@andrewtavis
Copy link
Member

Hey @RyanPaulGannon, would you have a moment to do an initial review here? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Included as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants