-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update utils.py #63
Update utils.py #63
Conversation
Change the _find docstring to _load_json
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you! Maintainer checklist
|
I see there was some confusion here, @Jk40git. Big thing is that we don't want the docstring to "be the docstring of the other one", but we want them to have the same style. For find we currently have:
What this should be is:
The big thing is that everywhere that we have
And everywhere we have
Can you convert the docstring of |
Changes to docstring of _find
@andrewtavis Just made an edit #63 |
Nice, yes, this is looking good @Jk40git! Here are the other docstrings that need edits:
Want to send along another commit with all of these changes, and then we can close this up? In cases where there's a section that's not
as in the example above :) Let me know if there are any questions on this! |
Do you want me to change the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes sent along in the most recent commit finishes this up, @Jk40git. Thanks! Will move to the others now :)
Don't worry about the Mac builds, by the way. This is known in #61 :) |
Change the _find's docstring to _load_json's
Contributor checklist
Description
Related issue