-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive functionality #268
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
cc: @mhmohona, @andrewtavis if you don't like the interactive UI or if it is not user friendly for community, I can make another PR using asciimatics as @wkyoshida said. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @axif0! ✨
|
||
|
||
# MARK: Start interactive mode functionality | ||
def start_interactive_mode(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add docstring here, as well as for other functions.
One question on this, @axif0: What's the support from the packages you're using to display options as a grid? I'm quite conscious right now that as soon as we start adding in the new languages that people are working on, that we won't be able to see all the options on the screen anymore without displaying a grid. Do you think this is an option for the current dependencies? Also, don't we need dependencies added to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok lots of changes went through in my commit, but overall this is great, @axif0 😊
- Exit wasn't working
- We can now rerun data type only
- Minor color/style fixes
- Copy fixes (I changed export to request so it doesn't sound like the data is in Scribe-Data)
- Overall control fixes
- Asking the user if they want to continue when they didn't select something as the message was above the options for me, and is definitely going to be there for everyone as the options expand
This really is so cool :) :)
Contributor checklist
Description
The rich library enhances CLI output with colorful tables and messages, while questionary provides interactive prompts for user input.
Related issue
--interactive
CLI mode #203