Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive functionality #268

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Interactive functionality #268

merged 3 commits into from
Oct 11, 2024

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Oct 7, 2024

Contributor checklist


Description

The rich library enhances CLI output with colorful tables and messages, while questionary provides interactive prompts for user input.

attempt 2

Related issue

Copy link

github-actions bot commented Oct 7, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@axif0
Copy link
Contributor Author

axif0 commented Oct 7, 2024

cc: @mhmohona, @andrewtavis if you don't like the interactive UI or if it is not user friendly for community, I can make another PR using asciimatics as @wkyoshida said.

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2024
Copy link
Member

@mhmohona mhmohona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @axif0! ✨



# MARK: Start interactive mode functionality
def start_interactive_mode():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docstring here, as well as for other functions.

@andrewtavis
Copy link
Member

One question on this, @axif0: What's the support from the packages you're using to display options as a grid? I'm quite conscious right now that as soon as we start adding in the new languages that people are working on, that we won't be able to see all the options on the screen anymore without displaying a grid. Do you think this is an option for the current dependencies?

Also, don't we need dependencies added to the requirements.txt file?

@andrewtavis
Copy link
Member

Sorry the dependencies are there... Lots of PRs over the last few days. I'm going to start testing this and comparing it against the work to re-ask users for options that was done in #216 and #239. I'm assuming that the dependencies will do this, but we'll see :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lots of changes went through in my commit, but overall this is great, @axif0 😊

  • Exit wasn't working
  • We can now rerun data type only
  • Minor color/style fixes
  • Copy fixes (I changed export to request so it doesn't sound like the data is in Scribe-Data)
  • Overall control fixes
  • Asking the user if they want to continue when they didn't select something as the message was above the options for me, and is definitely going to be there for everyone as the options expand

This really is so cool :) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants