Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RANGE_* constants #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use RANGE_* constants #6

wants to merge 5 commits into from

Conversation

RiftLurker
Copy link
Contributor

This implements the range limitations by the constants RANGE_* that are added with PR#2 in screeps/common.

@RiftLurker RiftLurker mentioned this pull request Dec 19, 2016
Open
@artch artch self-assigned this Jan 18, 2017
@artch artch removed their assignment Jan 18, 2017
@JestDotty
Copy link

why RANGE_HARVEST_MINERAL & RANGE_HARVEST_SOURCE? The command for both is harvest & same range, wouldn't it make more sense to just be RANGE_HARVEST?

@TheRealMaxion
Copy link

@JestDotty My guess is that it would allow them to have different ranges should a private server choose to do so.

@o4kapuk o4kapuk self-assigned this Sep 12, 2018
o4kapuk
o4kapuk approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@o4kapuk o4kapuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

@semperrabbit
Copy link

This is over 2 years old. Is there going to be any movement on this? It looks like the conflicting files still need to get fixed. it is approved though.

semperrabbit added a commit to semperrabbit/screeps_engine that referenced this pull request Jul 16, 2019
@semperrabbit
RANGE_* constants for creeps, structures and powercreeps
a8a8f7f 
clone and fixed merge conflicts of screeps/engine PR screeps#6 by PostCrafter
added RANGE_* constants for PowerCreeps
RiftLurker pushed a commit to RiftLurker/screeps-engine that referenced this pull request Oct 27, 2020
@semperrabbit @RiftLurker
RANGE_* constants for creeps, structures and powercreeps
6431a58 
clone and fixed merge conflicts of screeps/engine PR screeps#6 by PostCrafter
added RANGE_* constants for PowerCreeps
RiftLurker and others added 3 commits October 27, 2020 10:44
@RiftLurker
Copy link
Contributor Author

I've rebased the branch and added RANGE_RENEW_POWERCREEP and RANGE_HARVEST_DEPOSIT (see corresponding changes in screeps/common#2).

@semperrabbit
Copy link

dang, im excited, this would be a culmination of a set of almost 4 yr PRs. I hope this gets through, @o4kapuk, as this will allow more possible changes for follow-on seasonal servers 👍.

Ideas include combat, but adjusted ranged heal and increased RANGE_ATTACK or GCL race, but different attackController, upgradeController, claimController and upgradeController ranges...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o4kapuk o4kapuk o4kapuk approved these changes

Assignees

@o4kapuk o4kapuk

Labels
enhancement verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RiftLurker @JestDotty @TheRealMaxion @semperrabbit @o4kapuk @artch