Add code examples #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Basic example - Example for efficiency enhancements during RTC (cursor constraint and RTCDataChannel) fixes screen-share#6
fred-wang
added a commit
to fred-wang/mouse-events
that referenced
this pull request
Jun 27, 2023
An example is also added in screen-share#18 fixes screen-share#15
This was referenced Jun 27, 2023
index.html
Outdated
| video: true, | ||
| controller: controller, | ||
| }); | ||
| videoElement.srcObject = mediaStream; |
There was a problem hiding this comment.
This line can probably be removed.
|
Thanks for the review!
OK done. Although it seems we would need to run it again for changes made elsewhere... |
|
I've run the formatter for you and committed it directly. Hope you don't mind. |
|
@eladalon1983 OK, I had actually manually reverted the formatting part unrelated to that commit, but I don't mind. |
eladalon1983
approved these changes
Jul 3, 2023
|
@eladalon1983 Can you please merge this? (I can't) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6
Preview | Diff