Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add unsupported browser error #191

Merged
merged 1 commit into from
Aug 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions ui/src/useRoom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -317,17 +317,31 @@ export const useRoom = (config: UIConfig): UseRoom => {
const share = async () => {
if (!navigator.mediaDevices) {
enqueueSnackbar(
'Could not start presentation. (mediaDevices undefined) Are you using https?',
{
variant: 'error',
persist: true,
}
'Could not start presentation. Are you using https? (mediaDevices undefined)',
{variant: 'error', persist: true}
);
return;
}
stream.current = await navigator.mediaDevices.getDisplayMedia({
video: {frameRate: loadSettings().framerate},
});
if (typeof navigator.mediaDevices.getDisplayMedia !== 'function') {
enqueueSnackbar(
`Could not start presentation. Your browser likely doesn't support screensharing. (mediaDevices.getDeviceMedia ${typeof navigator.mediaDevices.getDisplayMedia})`,
{variant: 'error', persist: true}
);
return;
}
try {
stream.current = await navigator.mediaDevices.getDisplayMedia({
video: {frameRate: loadSettings().framerate},
});
} catch (e) {
console.log('Could not getDisplayMedia', e);
enqueueSnackbar(`Could not start presentation. (getDisplayMedia error). ${e}`, {
variant: 'error',
persist: true,
});
return;
}

stream.current?.getVideoTracks()[0].addEventListener('ended', () => stopShare());
setState((current) => (current ? {...current, hostStream: stream.current} : current));

Expand Down
Loading