Clean up SVG renderer code #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
commented
Jan 7, 2021
| this._context.setTransform(1, 0, 0, 1, 0, 0); | ||
| // Set the CSS style of the canvas to the actual measurements. | ||
| this._canvas.style.width = bbox.width; | ||
| this._canvas.style.height = bbox.height; |
There was a problem hiding this comment.
Copying this comment over from the other PR: this was added way back in scratchfoundation/scratch-render@b35f684 and we were unable to determine why, exactly.
adroitwhiz
commented
Jan 7, 2021
| We provide [Scratch](https://scratch.mit.edu) free of charge, and want to keep it that way! Please consider making a [donation](https://secure.donationpay.org/scratchfoundation/) to support our continued engineering, design, community, and resource development efforts. Donations of any size are appreciated. Thank you! |
There was a problem hiding this comment.
No idea what changed here--doesn't seem to be missing a newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
A step towards #211 and scratchfoundation/scratch-render#594
Proposed Changes
This includes the first 3 commits from #127, with the requested changes made:
SvgRenderer, and update the documentation and playground to match.SvgRenderer's properties.SvgRenderer._drawFromImage.Reason for Changes
These changes make it easier to split
SvgRendererup into multiple parts, some of which can be moved into the specific repositories which need them, and allow more complex changes like the ones required by scratchfoundation/scratch-render#594 to be implemented without touching this repo.Test Coverage
All existing tests pass