Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync new Zyte API features #218

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

Gallaecio
Copy link
Contributor

No description provided.

@Gallaecio
Copy link
Contributor Author

New attribute to take into account: #222

@Gallaecio
Copy link
Contributor Author

We also need to make sure it is possible to disable networkCapture from the automap setting by setting it to False on the request metadata key.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 58.06452% with 13 lines in your changes missing coverage. Please review.

Project coverage is 97.09%. Comparing base (64ad254) to head (b89aa87).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
scrapy_zyte_api/_params.py 55.17% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   97.87%   97.09%   -0.78%     
==========================================
  Files          14       14              
  Lines        1597     1616      +19     
  Branches      296      302       +6     
==========================================
+ Hits         1563     1569       +6     
- Misses         14       26      +12     
- Partials       20       21       +1     
Files with missing lines Coverage Δ
scrapy_zyte_api/_request_fingerprinter.py 98.33% <100.00%> (ø)
scrapy_zyte_api/providers.py 94.65% <ø> (ø)
scrapy_zyte_api/_params.py 96.32% <55.17%> (-3.68%) ⬇️
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant