Skip to content
This repository has been archived by the owner on Dec 28, 2023. It is now read-only.

[README.md] better info about parameters #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pawelmhm
Copy link

@pawelmhm pawelmhm commented Mar 22, 2021

added better example of paramters to docs + link to page with all parameters @edorofeev

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #16 (48c0f5f) into master (8cefd24) will not change coverage.
The diff coverage is n/a.

❗ Current head 48c0f5f differs from pull request most recent head 82659f0. Consider uploading reports for the commit 82659f0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          179       179           
=========================================
  Hits           179       179           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cefd24...82659f0. Read the comment docs.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Adrián Chaves <[email protected]>
@pawelmhm
Copy link
Author

@Gallaecio one thing to note is that some parameters are not documented in the website of Fetch API. I'm not confident if they are official or not? @edorofeev Should we also add parameters to website? I can do it too, it will speed up things next time I need to set up some spider for Fetch api

Copy link
Member

@elacuesta elacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, not merging yet because of the open questions at #16 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants