Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we reap SSH process on Close() #177

Merged

Commits on Apr 4, 2024

  1. Make sure we reap SSH process on Close()

    System transport can get stuck on the Read call because of
    pty implementation details (see scrapli#174)
    for more details.
    
    This makes sure that we kill the SSH process when the transport
    is closed, and in turn makes sure that the rest of the components (channel, drivers)
    can shutdown properly.
    
    I also added a test simulating a blocking (stuck) SSH server
    and a non blokcing SSH server (non blocking showed that it's fine
    to kill an already defunct process).
    
    Signed-off-by: Francois Espinet <[email protected]>
    netixx authored and Francois Espinet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    63b393a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    36922a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60d40c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    118e9d0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9b32b32 View commit details
    Browse the repository at this point in the history