Add run shell definition to ios-xr #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netixx
force-pushed
the
netixx/add-xr-run-shell
branch
from
c631961
to
d8c5674
Compare
|
nice! I think the ci failure was just gh actions being horrendously slow but will run that again for kicks. is this "run" level pretty standard in iosxr nowadays? my exp stopped around 6.x stuff and it was a long time ago so memory is fuzzy :D -- if theres any specific version where this was added that you know of maybe we can add a comment in the platform yaml for extra clarity? otherwise LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for run shell privilege on Cisco IOS-XR.
Run shell can be required to move files around (my use-case was setting my own certificates/ca for grpc).
More details in: #160.