Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue#66 #67

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

AmPhIbIaN26
Copy link

@AmPhIbIaN26 AmPhIbIaN26 commented May 3, 2021

Regarding isssues#66, added encoding='utf8' to the open() function on line 23 in __init__.py. This fixes the pytest issues for Hindi, Spanish and Russian on Windows.

I have implemented parsing for roman, for the case of parsing any roman numeral in a sentence you have to specify the language.
I have implemented parsing for roman, for the case of parsing any roman numeral in a sentence you have to specify the language.
added encoding='utf8' to __init__.py
This reverts commit b36483e.
added encoding='utf8' to __init__.py
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #67 (4effdd8) into master (c834854) will not change coverage.
The diff coverage is n/a.

❗ Current head 4effdd8 differs from pull request most recent head 3ee2ed4. Consider uploading reports for the commit 3ee2ed4 to get more accurate results

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          86       86           
  Lines         328      328           
  Branches       60       60           
=======================================
  Hits          324      324           
  Misses          1        1           
  Partials        3        3           

@Gallaecio
Copy link
Member

Gallaecio commented May 4, 2021

Nice.

Did you check if there were any other open calls without the encoding parameters in the code base? (if so, we should aim to fix them all at once here).

It would also be a great opportunity to add Windows to the CI.

@AmPhIbIaN26
Copy link
Author

AmPhIbIaN26 commented May 13, 2021

Hi @Gallaecio hope you and your family are safe.
I looked and did not find any other open calls without encoding, also added Windows to the CI. I wanted to ask, why are there two github action configurations, one with python39 testing and one without it?

@Gallaecio
Copy link
Member

Could you remove the one without Python 3.9? I believe it is an unused, leftover file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants