-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Issue#66 #67
base: master
Are you sure you want to change the base?
Fixed Issue#66 #67
Conversation
I have implemented parsing for roman, for the case of parsing any roman numeral in a sentence you have to specify the language.
This reverts commit 386fdd9.
I have implemented parsing for roman, for the case of parsing any roman numeral in a sentence you have to specify the language.
This reverts commit 6658bc4.
This reverts commit 81ed627.
This reverts commit 386fdd9.
added encoding='utf8' to __init__.py
This reverts commit b36483e.
This reverts commit ce81365.
This reverts commit c6285cb.
This reverts commit ff64b93.
added encoding='utf8' to __init__.py
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 86 86
Lines 328 328
Branches 60 60
=======================================
Hits 324 324
Misses 1 1
Partials 3 3 |
Nice. Did you check if there were any other It would also be a great opportunity to add Windows to the CI. |
Hi @Gallaecio hope you and your family are safe. |
Could you remove the one without Python 3.9? I believe it is an unused, leftover file. |
Regarding isssues#66, added
encoding='utf8'
to theopen()
function on line 23 in__init__.py
. This fixes the pytest issues for Hindi, Spanish and Russian on Windows.