Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG version of body_bg from Common Theme #92

Merged
merged 2 commits into from
Jan 6, 2024
Merged

SVG version of body_bg from Common Theme #92

merged 2 commits into from
Jan 6, 2024

Conversation

SYwaves
Copy link
Contributor

@SYwaves SYwaves commented Jan 5, 2024

No description provided.

@SYwaves
Copy link
Contributor Author

SYwaves commented Jan 5, 2024

Demo: http://mast-nav.wikidot.com/estrella-mod:header-img

@SYwaves SYwaves requested a review from emmiegit January 5, 2024 12:30
emmiegit
emmiegit reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@emmiegit emmiegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

Two questions:

  1. Are we going to do anything with the PNG version?
  2. How do we cite the use of this image, since it's from the Common Theme?

@SYwaves
Copy link
Contributor Author

SYwaves commented Jan 6, 2024

I think it's fine to leave it as is for th time being, and remove it later down the line.

How did we attribute the SVG logo? We could do the same here. If not yet done, a licensebox on the front page for Sigma-10 and its constituents is good.

@SYwaves SYwaves merged commit 864c71d into main Jan 6, 2024
2 checks passed
@SYwaves SYwaves deleted the svg-header branch January 6, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmiegit emmiegit emmiegit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYwaves @emmiegit