Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move overflow-wrap property #89

Merged
merged 1 commit into from
Oct 16, 2023
Merged

move overflow-wrap property #89

merged 1 commit into from
Oct 16, 2023

Conversation

SYwaves
Copy link
Contributor

@SYwaves SYwaves commented Oct 16, 2023 •
edited
Loading

overflow-wrap should be a more universally applied property - I've moved it to #main-content outside the media query (body was considered, but I wanted to avoid possible layout shift with #header and #side-bar)

Here's a simulated screenshot:
image

With:
image

@SYwaves SYwaves requested a review from emmiegit October 16, 2023 14:32
emmiegit
emmiegit approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@emmiegit emmiegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Too-long lines causing page breaks is an occasionally occurring issue.

@emmiegit emmiegit merged commit 3b0044d into main Oct 16, 2023
2 checks passed
@emmiegit emmiegit deleted the overflow-wrap branch October 16, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmiegit emmiegit emmiegit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYwaves @emmiegit