Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

159 #162

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

159 #162

wants to merge 2 commits into from

Conversation

vishweshsoni
Copy link

Fixes #159

Changes in Pull Request

  • CommonFeedComponent ObjectId of User Insted of UserID
  • TypeCasting in Post.js

Impact

  • Server stop Crashing and Like service Working Properly

Check if you have done the following before creating the PR

  • console logs have been deleted
  • No commented code (If commented the reasons are given)

Rupeshiya
Rupeshiya reviewed Dec 22, 2019
View reviewed changes
Copy link

@Rupeshiya Rupeshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Looks good to me @vishweshsoni
Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rupeshiya Rupeshiya Rupeshiya left review comments

@shivamarora96 shivamarora96 Awaiting requested review from shivamarora96

@psnmissaka psnmissaka Awaiting requested review from psnmissaka

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server crashes when you like an issue in the common feed
2 participants
@vishweshsoni @Rupeshiya