Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from google:master #247

Open
wants to merge 1,189 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1189 commits
Select commit Hold shift + click to select a range
f88cd5c
Add Javadoc to the guava-android copy of `Equivalence.doEquivalent`.
cpovirk Apr 24, 2024
730ca9f
Bump actions/checkout from 4.1.3 to 4.1.4
dependabot[bot] Apr 24, 2024
21fb201
Suppress or work around false-positive errors from the forthcoming ve…
cpovirk Apr 24, 2024
348be7b
Actually write the manifest we generate to the jar.
DarkaMaul Apr 26, 2024
093852e
Document that we now run our Android tests under Lollipop.
cpovirk Apr 26, 2024
5004744
Bump gradle/wrapper-validation-action from 3.3.1 to 3.3.2
dependabot[bot] Apr 26, 2024
9596c99
Update Animal Sniffer scents to Lollipop.
cpovirk Apr 26, 2024
e075e89
Bump github/codeql-action from 3.25.2 to 3.25.3
dependabot[bot] Apr 29, 2024
70a9811
Fixed a potential `NullPointerException` in `ImmutableMap.Builder` on…
Apr 30, 2024
fddc95d
Micro-optimize `singletonIterator` one more time.
cpovirk Apr 30, 2024
96fca0b
Make our `Collector` APIs available in `guava-android`.
cpovirk Apr 30, 2024
57f76e3
Prepare for release 33.2.0.
cpovirk May 1, 2024
2f4154d
Roll back the most recent `singletonIterator` optimization attempt.
cpovirk May 3, 2024
ba820c6
Roll back middle atttempt at micro-optimizing `singletonIterator`.
cpovirk May 3, 2024
b15afd5
Roll back initial atttempt at micro-optimizing `singletonIterator`.
cpovirk May 3, 2024
8f212ba
Add missing `@since` tag for `merge` in `TreeRangeMap` and `Immutable…
cpovirk May 4, 2024
381835d
Accept `AutoCloseable` in the Android copy of `ClosingFuture`, too.
cpovirk May 7, 2024
61d3f25
Use `Throwable.addSuppressed` in the Android copy of `ServiceManager`.
cpovirk May 7, 2024
6342a23
Unconditionally use `Throwable.addSuppressed` in `Closer`.
cpovirk May 7, 2024
1b3969e
Bump actions/checkout from 4.1.4 to 4.1.5
dependabot[bot] May 7, 2024
b9b6084
Standardize parameter names across `Immutable*.of(...)` methods.
cpovirk May 8, 2024
8b70996
Bump github/codeql-action from 3.25.3 to 3.25.4
dependabot[bot] May 8, 2024
243b327
Bump ossf/scorecard-action from 2.3.1 to 2.3.3
dependabot[bot] May 10, 2024
aeadb63
Update the documentation of `RegularImmutableMap`.
cpovirk May 11, 2024
cc28751
Bump github/codeql-action from 3.25.4 to 3.25.5
dependabot[bot] May 13, 2024
7c934a2
Add a J2kt super-source implementation of DirectExecutorService that …
stefanhaustein May 15, 2024
225c1b5
Internal change.
cpovirk May 15, 2024
dc200d3
Internal change.
cpovirk May 16, 2024
6dd1cb1
Reenable `NullPointerTester` tests for our internal Android-emulator …
cpovirk May 17, 2024
ec7069a
Bump actions/checkout from 4.1.5 to 4.1.6
dependabot[bot] May 17, 2024
dd2fac8
Remove `@Beta` from `TestingExecutors.sameThreadScheduledExecutor`.
cpovirk May 17, 2024
f0c7099
Remove workaround for an Android bug that was fixed at some point bef…
cpovirk May 17, 2024
4ed4972
Remove workaround for an ancient Android `toArray` bug.
cpovirk May 18, 2024
f238ae4
Bump github/codeql-action from 3.25.5 to 3.25.6
dependabot[bot] May 20, 2024
3f61870
Change `InetAddress`-`String` conversion methods to preserve the scop…
java-team-github-bot May 24, 2024
c4b883d
Use Number.prototype.toPrecision in Platform.formatCompact4Digits.
gkdn May 27, 2024
142ddbc
Fix `@VisibleForTesting` violations.
cpovirk May 28, 2024
f74135f
Eliminate the need for a few `rawtypes` and `unchecked` suppressions.
cpovirk May 28, 2024
c497a97
Use `AssertionError(String, Throwable)` instead of supplying the caus…
cpovirk May 29, 2024
6c67228
Migrate usages of obsolete Guava APIs.
cpovirk May 31, 2024
25322a7
Prepare for release 33.2.1.
cpovirk May 31, 2024
c86c09d
Remove `@Beta` from the `guava-android` `Collector` APIs.
cpovirk Jun 2, 2024
62c7fbb
Bump deps.
cpovirk Jun 3, 2024
f94db26
Group all dependabot updates together in the same commit to avoid mer…
chaoren Jun 4, 2024
0d37269
Bump github/codeql-action from 3.25.6 to 3.25.8
dependabot[bot] Jun 4, 2024
d328b51
Remove unused `writeObject` method.
cpovirk Jun 7, 2024
635571e
Suppress https://errorprone.info/bugpattern/SunApi warnings.
cpovirk Jun 7, 2024
9ea6816
Use natural units for durations.
cpovirk Jun 10, 2024
e0e44b5
Fix `MissingOverride` findings.
cpovirk Jun 10, 2024
c2bbd73
Remove workaround for [ancient Android `unmodifiableMap` bug](https:/…
cpovirk Jun 10, 2024
fdfbed1
Migrate some tests and testing infrastructure from `AssertionFailedEr…
cpovirk Jun 11, 2024
a5f9bca
Make `CacheBuilder` `Duration` overloads available in `guava-android`.
cpovirk Jun 13, 2024
808e079
Use imports instead of fully qualified types.
cpovirk Jun 14, 2024
95b394c
Lazily initialize the map in ImmutableMultimap.Builder.
lowasser Jun 14, 2024
040d0b9
Use a Map<K, ImmutableCollection.Builder<V>> instead of Map<K, Collec…
lowasser Jun 14, 2024
22151fa
Bump the github-actions group with 3 updates
dependabot[bot] Jun 17, 2024
b310b7e
Update Sec-Ch-UA-Form-Factor to Sec-Ch-UA-Form-Factors to follow late…
java-team-github-bot Jun 19, 2024
1648ef7
Mark Synchronized.java and references as J2ktIncompatible.
stefanhaustein Jun 21, 2024
20348c7
Remove unnecessary explicit NaN check.
moinb Jun 21, 2024
263712a
Fix typo.
testwill Jun 21, 2024
cd11e83
Remove helper methods that are unused externally from the external co…
cpovirk Jun 21, 2024
faf36af
Minor followup from cl/645331066:
cpovirk Jun 21, 2024
f46b178
Document and add suppressions for our intentional use of `&` and `|`.
cpovirk Jun 24, 2024
19cfef2
Address https://errorprone.info/bugpattern/FunctionalInterfaceClash w…
cpovirk Jun 24, 2024
8c31d52
Bump gradle/wrapper-validation-action in the github-actions
dependabot[bot] Jun 24, 2024
dc80e7e
Optimize Futures.allAsList handling of already completed Futures. Ski…
java-team-github-bot Jun 24, 2024
2a3fa8f
Internal change.
cpovirk Jun 25, 2024
76fca99
Remove `@Beta` from the `Duration` overload of `Suppliers.memoizeWith…
cpovirk Jun 25, 2024
93c7a3a
Remove accidental whitespace from cl/646505537.
cpovirk Jun 25, 2024
b50df33
Suggest using streams instead of `Maps.toMap()`.
java-team-github-bot Jun 25, 2024
4b96e43
Internal change.
java-team-github-bot Jun 26, 2024
4facd69
Bump Truth to 1.4.3.
cpovirk Jun 27, 2024
a869b86
Migrate from legacy com.google.gwt to org.gwtproject.
cpovirk Jun 28, 2024
e549ba5
Remove suppressions that are unnecessary now that our nullness checke…
cpovirk Jun 30, 2024
0a76ba8
Tweak code to avoid upsetting the nullness checker.
cpovirk Jul 1, 2024
9ba5fea
Bump github/codeql-action in the github-actions group
dependabot[bot] Jul 1, 2024
3618043
Address some `UnusedVariable` warnings.
cpovirk Jul 2, 2024
8b0d007
Suppress https://errorprone.info/bugpattern/Finalize warnings.
cpovirk Jul 2, 2024
c8829bf
Migrate JUnit `double` equality assertions to Truth.
cpovirk Jul 3, 2024
8dac907
Compare for equality, not approximate equality within a tolerance of …
cpovirk Jul 3, 2024
2c24eb8
Bump actions/upload-artifact in the github-actions group
dependabot[bot] Jul 8, 2024
ad57f52
Add a Sequential Executor implementation for the j2kt super source. A…
java-team-github-bot Jul 8, 2024
542e588
Downgrade to a version of `plexus-io` from before a performance impro…
cpovirk Jul 9, 2024
c94072c
Roll back suppressions for bogus nullness errors now that we've fixed…
cpovirk Jul 9, 2024
558c2be
Internal change.
kluever Jul 9, 2024
c28e652
Rename `HighwayHash64FunctionTest` to `HighwayHashFunctionTest`. Simp…
kluever Jul 9, 2024
2f6d618
Switch FutureCallbackTest to an explicit monitor for j2kt compatibility.
stefanhaustein Jul 10, 2024
7e66ec4
Remove Impossible from open-source release.
lowasser Jul 11, 2024
8b6d8bb
Use try-with-resources to close a `URLClassLoader`.
dk2k Jul 11, 2024
123ae0b
Fix a bad name for an exception parameter.
cpovirk Jul 12, 2024
4a2d302
Bump Truth to 1.4.4.
cpovirk Jul 12, 2024
354136f
Bump github/codeql-action in the github-actions group
dependabot[bot] Jul 16, 2024
61bfd84
Improve bug report template.
Marcono1234 Jul 16, 2024
63734b9
Use iteration instead of recursion in `Graphs.hasCycle`.
cpovirk Jul 18, 2024
514f212
Update links.
cpovirk Jul 19, 2024
e449414
Bump the github-actions group with 2 updates
dependabot[bot] Jul 22, 2024
5ccc169
Remove some references to Java 7.
cpovirk Jul 22, 2024
1dffea2
Clean up threads for `CacheBuilderTest` and `FuturesTest`.
aoli-al Jul 22, 2024
3dce9a2
Suppress an `UnusedVariable` warning for an unusual `Comparator` impl…
cpovirk Jul 22, 2024
e74da92
Update some comments / docs about JDK 7.
cpovirk Jul 22, 2024
04c1b7a
Reimplement our `compare` methods in terms of JDK equivalents.
cpovirk Jul 23, 2024
5041fbe
Migrate off our `Charsets` constants, and further discourage usage.
cpovirk Jul 23, 2024
76f87bb
Bump a few Maven plugins.
cpovirk Jul 24, 2024
71666ca
Hard-code Java versions for plugins other than `maven-surefire-plugin`.
cpovirk Jul 24, 2024
41800d5
Suppress some https://errorprone.info/bugpattern/JUnit4ClassUsedInJUn…
cpovirk Jul 24, 2024
85c6f88
Fix some [style violations](https://google.github.io/styleguide/javag…
cpovirk Jul 24, 2024
5827422
Address some https://errorprone.info/bugpattern/NonApiType warnings.
cpovirk Jul 25, 2024
e2b7a33
Initialize our `Charsets` constants using the fields in `StandardChar…
cpovirk Jul 25, 2024
2466a09
Add `text/markdown` to `MediaType`
java-team-github-bot Jul 26, 2024
1a01958
Bump the github-actions group with 2 updates
dependabot[bot] Jul 30, 2024
372f6f0
Update Public Suffix List data.
java-team-github-bot Jul 31, 2024
a629c5d
Soften the comment about _deprecating_ Multimap factories, as it hasn…
java-team-github-bot Aug 2, 2024
8bab177
swap Charsets for StandardCharsets
kluever Aug 2, 2024
641b4c5
Bump the github-actions group with 2 updates
dependabot[bot] Aug 5, 2024
5f0e886
Make lock objects `transient`.
cpovirk Aug 5, 2024
cab8ad1
Update Public Suffix List data.
java-team-github-bot Aug 6, 2024
c784059
Fix or suppress `JUnitIncompatibleType` findings in Guava.
java-team-github-bot Aug 6, 2024
91b6ebe
Synchronize on empty arrays instead of `Integer` instances.
cpovirk Aug 6, 2024
c3d5b17
Allow size hinting for ImmutableMultimap and subtypes.
lowasser Aug 6, 2024
f7c5569
Make ImmutableSet.Builder.addAll(Set) smarter about sizing the intern…
lowasser Aug 6, 2024
636e580
Stop hashing in presized ImmutableSortedSet.Builders in java7 variant…
lowasser Aug 6, 2024
6bd3a14
Make ImmutableSet.Builder.addAll(Set) smarter about sizing the intern…
java-team-github-bot Aug 6, 2024
7c4ca41
Validate that ImmutableSortedSet.Builder is O(n log n).
lowasser Aug 9, 2024
36dfb16
Simplify the implementation of a test `Predicate`.
cpovirk Aug 12, 2024
0cb9cc6
Group overloads.
cpovirk Aug 12, 2024
e232035
Fix ImmutableList.Builder to throw a useful exception when its size w…
lowasser Aug 12, 2024
a4a7f6b
Recommend the JDK `compareUnsigned` methods over our equivalents.
cpovirk Aug 12, 2024
a94ff8b
Update nullness annotations after cl/662127972, and prepare for the f…
cpovirk Aug 16, 2024
e1eaeff
Prepare for release 33.3.0.
cpovirk Aug 16, 2024
55911e8
Bump the github-actions group with 2 updates
dependabot[bot] Aug 16, 2024
d619273
Suppress Error Prone findings locally.
cpovirk Aug 19, 2024
7c9455c
Bump github/codeql-action in the github-actions group
dependabot[bot] Aug 19, 2024
7810685
Synchronize on empty arrays instead of `Integer` instances.
cpovirk Aug 19, 2024
388e098
Call `Thread.suspend` and `resume` reflectively (when we even try to …
cpovirk Aug 22, 2024
137798d
Specify `@InlineMe` for `{Doubles,Floats}#compare`
Stephan202 Aug 23, 2024
508cef7
Changed `*.concat()` to throw `IllegalArgumentException` if the input…
Aug 27, 2024
bff7090
Stop testing code with inaccurate nullness annotations under J2KT.
cpovirk Aug 27, 2024
9c84ddb
Remove comments about compiling with JDK 8.
cpovirk Aug 29, 2024
27c5440
Bump github/codeql-action in the github-actions group
dependabot[bot] Aug 30, 2024
bb9fc23
Bump the github-actions group with 2 updates
dependabot[bot] Sep 4, 2024
930cc58
Bump actions/setup-java from 4.2.2 to 4.3.0 in the
dependabot[bot] Sep 9, 2024
7bc08c1
Remove stale comments about `@NonNull` annotations in the JDK.
cpovirk Sep 10, 2024
294f07d
Bump github/codeql-action in the github-actions group
dependabot[bot] Sep 16, 2024
e5b58e2
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code.
cpovirk Sep 17, 2024
6a070d8
Bump github/codeql-action in the github-actions group
dependabot[bot] Sep 23, 2024
a3b5188
Include `j2objc-annotations` in the Gradle runtime classpath.
cpovirk Sep 23, 2024
d9dbb15
Fix one instance of incorrect nullability of type argument in FluentI…
java-team-github-bot Sep 24, 2024
3c7c173
Prepare for release 33.3.1.
cpovirk Sep 24, 2024
7c0bf08
Add `application/cbor` to `MediaType`.
kstich Sep 26, 2024
f358c05
Use JDK 23 for compilation (and a few other plugins), while keeping o…
cpovirk Oct 1, 2024
503ba42
Add `HttpHeaders.ALT_SVC`; see https://datatracker.ietf.org/doc/html/…
kluever Oct 1, 2024
f640a0f
Bump the github-actions group with 3 updates
dependabot[bot] Oct 1, 2024
5da71a7
Fix some misconfigured collections test suites that were passing due …
chaoren Oct 2, 2024
81be061
Fix `@Require` annotations so that features implied by absent feature…
chaoren Oct 5, 2024
a46565d
Provide an optimized copyOf method for TreeRangeMap
java-team-github-bot Oct 6, 2024
ed33d3d
Bump github/codeql-action in the github-actions group
dependabot[bot] Oct 7, 2024
4d7c71e
Add `@RetainedLocalRef` to `volatile` `value` field references to res…
java-team-github-bot Oct 8, 2024
01e6a55
Refactor `getDoneValue(Object obj)` to improve readability of `Cancel…
java-team-github-bot Oct 8, 2024
49776fd
Address https://errorprone.info/bugpattern/Interruption warnings.
cpovirk Oct 8, 2024
99d2ced
Remove @GwtIncompatible from LongMath.checkedSubtract
java-team-github-bot Oct 9, 2024
f5ec2ab
add `ToStringHelper.omitEmptyValues()`. Fixes https://github.com/goog…
kluever Oct 9, 2024
d40589d
Avoid backticks in Javadoc.
cpovirk Oct 10, 2024
b84a41d
n/a
lowasser Oct 11, 2024
ccb3c85
Bump the github-actions group with 3 updates
dependabot[bot] Oct 14, 2024
9be5c72
Bump Maven to 3.9.9 and Wrapper to 3.3.2.
cpovirk Oct 14, 2024
77243d6
Add a note about `Thread.Factory` for Java 21+ users. See https://git…
kluever Oct 14, 2024
0a29129
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.col…
cpovirk Oct 15, 2024
5338f7c
Upgrade to a version of `plexus-io` from after a performance improvem…
cpovirk Oct 16, 2024
503c9eb
Add Fingerprint2011 to ChecksumBenchmark
java-team-github-bot Oct 16, 2024
10d4b1b
Inline a method that mainly serves to confuse the compiler's reachabi…
cpovirk Oct 16, 2024
98d5528
Address https://errorprone.info/bugpattern/UnnecessaryDefaultInEnumSw…
cpovirk Oct 16, 2024
702e4b2
Disable `Java7ApiChecker` for our *tests*, removing most of its suppr…
cpovirk Oct 16, 2024
ca12c33
Address [CatchFail](https://errorprone.info/bugpattern/CatchFail), [S…
cpovirk Oct 17, 2024
8f747d0
Migrate off `Throwables.propagate`, and stop rethrowing exceptions fr…
cpovirk Oct 17, 2024
0e2fa3e
Address https://errorprone.info/bugpattern/ThreadPriorityCheck warnings.
cpovirk Oct 17, 2024
1337405
Use `addSuppressed` in `AbstractExecutionThreadService`, and otherwis…
cpovirk Oct 17, 2024
2212495
Migrate more code to use `UndeclaredThrowableException`.
cpovirk Oct 17, 2024
dc423d2
Address [StaticQualifiedUsingExpression](https://errorprone.info/bugp…
cpovirk Oct 17, 2024
585b93a
Restore the behavior of throwing an `IllegalArgumentException` directly.
cpovirk Oct 17, 2024
7b62a51
Point users to [`Math.clamp`](https://docs.oracle.com/en/java/javase/…
cpovirk Oct 17, 2024
9597b0d
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.col…
cpovirk Oct 17, 2024
8a1c90e
Prepare for usage of `ReflectionFreeAssertThrows` from more packages:
cpovirk Oct 17, 2024
99be0a4
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.col…
cpovirk Oct 17, 2024
6082782
Make `Splitter.splitToStream` available to Android users.
cpovirk Oct 17, 2024
b0461b7
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.cac…
cpovirk Oct 18, 2024
b045bf3
Suppress a suggestion that we use the `Duration` overload.
cpovirk Oct 18, 2024
f5108a3
Use some static imports.
cpovirk Oct 18, 2024
dc12fb2
Address [InitializeInline](https://errorprone.info/bugpattern/Initial…
cpovirk Oct 18, 2024
3a8463a
Use some static imports.
cpovirk Oct 18, 2024
266b30c
Use some static imports.
cpovirk Oct 18, 2024
8bbbefd
Use _more_ static imports.
cpovirk Oct 19, 2024
89ca0ef
Use some static imports.
cpovirk Oct 19, 2024
cdc2254
Make most `util.concurrent` `Duration` overloads available to Android…
cpovirk Oct 19, 2024
fea7a36
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.pri…
cpovirk Oct 19, 2024
6544c1e
Update links from code.google.com to github.com.
cpovirk Oct 21, 2024
f617e81
Use `assertThrows` even in GWT/J2CL/J2KT-compatible code, `common.net…
cpovirk Oct 21, 2024
031cefa
Remove a couple more obsolete workarounds for `FilterOutputStream` tr…
cpovirk Oct 21, 2024
9911c83
Internal change.
cpovirk Oct 21, 2024
79c9e7a
Remove a couple more obsolete workarounds for `FilterOutputStream` tr…
java-team-github-bot Oct 21, 2024
67f9149
Extract shared helper methods in `UrlEscapersTest` into `UrlEscaperTe…
cpovirk Oct 21, 2024
3d14f1d
Complete the automatable migration to `assertThrows`.
cpovirk Oct 21, 2024
10c64d9
Internal change.
cpovirk Oct 22, 2024
f9f3fff
Expose more Java 8 APIs to Android users.
cpovirk Oct 23, 2024
9938818
Use `@RetainedLocalRef` to keep J2ObjC from deallocating objects when…
cpovirk Oct 25, 2024
19fef9b
Avoid varargs allocations in `min`/`max` calls.
cpovirk Oct 25, 2024
309365e
Miscellaneous followup from cl/687404334.
cpovirk Oct 25, 2024
984f713
Expose more Java 8 APIs to Android users.
cpovirk Oct 25, 2024
c6c2680
Expose more Java 8 APIs to Android users.
cpovirk Oct 25, 2024
2f04514
Eliminate unnecessary conversion to byte array.
guoci Oct 26, 2024
b650b9f
Expose more Java 8 APIs to Android users.
cpovirk Oct 26, 2024
ea06095
Copy an `Entry` to avoid undefined behavior after the `Map` is modified.
cpovirk Oct 27, 2024
dc30916
Roll forward cl/688155711, which was rolled back in cl/688191691.
cpovirk Oct 28, 2024
26ea2d4
Improve the error message for `assertNull` in test-suite-builder tests.
cpovirk Oct 28, 2024
2a36be1
Bump the github-actions group with 3 updates
dependabot[bot] Oct 29, 2024
167113a
Use **more** static imports.
cpovirk Oct 30, 2024
85d08ec
Use `Iterables.transform` again (except for one method that apparentl…
cpovirk Oct 30, 2024
5a63833
Remove unused import.
cpovirk Oct 30, 2024
664c80b
Fix another accidental use of varargs `min`/`max` calls.
cpovirk Oct 30, 2024
6ace8bc
Expose more Java 8 APIs to Android users.
cpovirk Oct 31, 2024
99d75d1
Add tester classes for Java 8 APIs to the Android flavor.
cpovirk Oct 31, 2024
9b0109c
Expose some `common.io` Java 8 APIs to Android users.
cpovirk Oct 31, 2024
68d28ec
Bump github/codeql-action in the github-actions group
dependabot[bot] Nov 11, 2024
c309175
Avoid iterating thrice in SetView.immutableCopy()
java-team-github-bot Nov 11, 2024
f7bb711
Document that `isInetAddress` and `forString` perform slightly differ…
cpovirk Nov 13, 2024
ed2c12a
Clarify comments about our usage of `@Ignore` and the associated supp…
cpovirk Nov 14, 2024
7a61ca9
Use `hasMessageThat` and `hasCauseThat`.
cpovirk Nov 15, 2024
747dd4b
Fix a tiny Javadoc error on UnsignedInteger.doubleValue.
java-team-github-bot Nov 15, 2024
166bb20
Link to Java 21 Javadoc instead of Java 9.
cpovirk Nov 15, 2024
9166ed0
Bump github/codeql-action in the github-actions group
dependabot[bot] Nov 18, 2024
3853b98
Stop warning that Caffeine requires Java 8.
cpovirk Nov 20, 2024
c799c38
Fix some Javadoc warnings, mostly around the use of the default const…
cpovirk Nov 20, 2024
27bb9c2
Fix typo from cl/698442998.
cpovirk Nov 20, 2024
4d4b29c
Add docs for `TreeRangeMap`, including `@since` tag for the `copyOf` …
cpovirk Nov 20, 2024
45e6be2
Deprecate `Charsets` constants.
kluever Nov 25, 2024
74c75ca
Bump github/codeql-action in the github-actions group
dependabot[bot] Nov 25, 2024
cf508b7
Bump Error Prone to 2.36.0, including setting `--should-stop=ifError=…
cpovirk Nov 26, 2024
335950b
Remove obsolete link to ancient site.
cpovirk Nov 26, 2024
8a24204
Internal change
java-team-github-bot Nov 27, 2024
5d6e2bd
Suppress https://errorprone.info/bugpattern/ThrowIfUncheckedKnownUnch…
cpovirk Dec 4, 2024
6832b54
Remove a test that creates a `SecurityManager`.
eamonnmcmanus Dec 5, 2024
03d3b70
Internal change.
eamonnmcmanus Dec 6, 2024
3bb6101
Improve the calculation of the optimal number of hash functions for a…
Romain-E Dec 8, 2024
3644d61
Remove tests that create a `SecurityManager`.
eamonnmcmanus Dec 9, 2024
54cc5ea
Make `Joiner` sometimes use `String.join`, which was [optimized](http…
cpovirk Dec 10, 2024
983c106
Fix/suppress more warnings.
cpovirk Dec 10, 2024
2aa8fd9
Bump github/codeql-action in the github-actions group
dependabot[bot] Dec 10, 2024
e307cae
Remove tests that rely on a `SecurityManager`.
eamonnmcmanus Dec 11, 2024
62c6187
Recommend `Cleaner` instead of `FinalizableReferenceQueue`.
eamonnmcmanus Dec 12, 2024
a124c1e
Release `testMyServerExampleWithCleaner` publicly.
cpovirk Dec 12, 2024
660e5dc
Prefactoring for future changes that will avoid using `Unsafe`.
cpovirk Dec 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
99 changes: 99 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
name: Bug Report
description: Something is not working as expected
labels: ["type=defect"]
body:
- type: markdown
attributes:
value: >
Thank you for filing a bug report. Please help us identify and resolve the bug by filling
out the following fields. Before we begin, please make sure that the bug is still present in
the [latest](https://github.com/google/guava/releases/latest) version of Guava available.
If it's already fixed in the latest version of Guava, then please just update your Guava
version instead.

- type: input
attributes:
label: Guava Version
description: Which version of Guava are you using?
placeholder: e.g., 33.2.1-jre
validations:
required: true

- type: textarea
attributes:
label: Description
description: Please describe the issue you encountered.
validations:
required: true

- type: textarea
attributes:
label: Example
description: >
Please provide a [Short, Self Contained, Correct (Compilable), Example](http://sscce.org/)
demonstrating the bug.
render: java
validations:
required: true

- type: textarea
attributes:
label: Expected Behavior
description: What did you expect to happen?
validations:
required: true

- type: textarea
attributes:
label: Actual Behavior
description: What actually happened?
validations:
required: true

- type: dropdown
attributes:
label: Packages
description: If this issue is package-specific, then please select the relevant packages.
multiple: true
options:
- com.google.common.annotations
- com.google.common.base
- com.google.common.cache
- com.google.common.collect
- com.google.common.escape
- com.google.common.eventbus
- com.google.common.graph
- com.google.common.hash
- com.google.common.io
- com.google.common.math
- com.google.common.net
- com.google.common.primitives
- com.google.common.reflect
- com.google.common.testing
- com.google.common.util.concurrent

- type: dropdown
attributes:
label: Platforms
description: If this issue is platform-specific, then please select the relevant platforms.
multiple: true
options:
- Android
- GWT
- Java 8
- Java 11
- Java 17
- Java 21

- type: checkboxes
attributes:
label: Checklist
options:
- label: >
I agree to follow the
[code of conduct](https://github.com/google/.github/blob/master/CODE_OF_CONDUCT.md).
required: true
- label: >
I can reproduce the bug with the
[latest](https://github.com/google/guava/releases/latest) version of Guava available.
required: true
156 changes: 156 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_addition_request.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
name: Feature Addition Request
description: I want to add a new feature
labels: ["type=addition"]
body:
- type: markdown
attributes:
value: >
Filing feature requests is one of the most popular ways to contribute to Guava.


Be aware, though: most feature requests are not accepted, even if they're suggested by
a full-time Guava team member. [Feedback](https://stackoverflow.com/a/4543114) from our
users indicates that they really appreciate Guava's high power-to-weight ratio. It's
important to us to keep Guava as easy to use and understand as we can. That means boiling
features down to compact but powerful abstractions, and controlling feature bloat carefully.


Guava's main yardstick for evaluating proposed features can be summed up as [utility times
ubiquity](https://github.com/google/guava/wiki/PhilosophyExplained#utility-times-ubiquity).


#### Utility: compare with alternatives


There is always *some* alternative to adding a new feature to Guava, even if it's just
forking Guava yourself.


We want to see that new features have some significant advantage over the alternatives.
These advantages can take
[many forms](https://github.com/google/guava/wiki/PhilosophyExplained#utility), but taking
the time to discuss them in detail will make it much clearer why this feature should be
added to Guava.


Please fill out the following fields to give us a better understanding of your proposed
feature and its potential value for other Guava users.

- type: textarea
attributes:
label: 1. What are you trying to do?
validations:
required: true

- type: textarea
attributes:
label: 2. What's the best code you can write to accomplish that without the new feature?
validations:
required: true

- type: textarea
attributes:
label: 3. What would that same code look like if we added your feature?
validations:
required: true

- type: markdown
attributes:
value: >
Comparing two approaches to a use case side by side can make it easier to examine the
differences between them.


Additionally, it's very useful to us if you can provide a "straw API" &mdash; what the
method signatures would look like, for example, even if the method and class names are still
in flux. This can make the feature you're suggesting much clearer to us.

- type: textarea
attributes:
label: (Optional) What would the method signatures for your feature look like?
placeholder: |
e.g.,
public static <E> ImmutableList<E> of();
public static <E> ImmutableList<E> of(E element);
public static <E> ImmutableList<E> of(E e1, E e2);
...
render: java
validations:
required: false

- type: markdown
attributes:
value: >
#### Ubiquity: provide concrete use cases


Did you *actually* encounter the need for this feature in a real-world scenario, or is it
just a feature that seems like a sensible addition to Guava?


Before new features get added to Guava, we really want to be sure that it's for a use case
that actually comes up in the real world. We want to hear the real-world use case so the
community can discuss and debate whether this feature is actually the *best* way to address
the real use case, or whether or not a different abstraction might be more appropriate.


It's okay if you can't provide complete context on a use case. We understand if you are not
able to discuss the full details of what you're working on.


But Guava aims to provide features that are useful across boundaries of projects, companies,
or even industries &mdash; utilities useful for a sizable proportion of all Java programmers
everywhere. If you can give enough detail such that any of us can imagine coming across
a similar need in our own work, that's extremely helpful in studying how broadly useful the
feature will be.

- type: textarea
attributes:
label: Concrete Use Cases
description: Please provide use cases that actually came up in the real world.
validations:
required: true

- type: dropdown
attributes:
label: Packages
description: Please select all of the packages that are relevant to this feature request.
multiple: true
options:
- com.google.common.annotations
- com.google.common.base
- com.google.common.cache
- com.google.common.collect
- com.google.common.escape
- com.google.common.eventbus
- com.google.common.graph
- com.google.common.hash
- com.google.common.io
- com.google.common.math
- com.google.common.net
- com.google.common.primitives
- com.google.common.reflect
- com.google.common.testing
- com.google.common.util.concurrent

- type: checkboxes
attributes:
label: Checklist
options:
- label: >
I agree to follow the
[code of conduct](https://github.com/google/.github/blob/master/CODE_OF_CONDUCT.md).
required: true
- label: >
I have read and understood the [contribution
guidelines](https://github.com/google/guava/wiki/HowToContribute#feature-requests).
required: true
- label: >
I have read and understood
[Guava's philosophy](https://github.com/google/guava/wiki/PhilosophyExplained), and
I strongly believe that this proposal aligns with it.
required: true
- label: >
I have visited the [idea graveyard](https://github.com/google/guava/wiki/IdeaGraveyard),
and did not see anything similar to this idea.
required: true
108 changes: 108 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_enhancement_request.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
name: Feature Enhancement Request
description: I want to make an existing feature better
labels: ["type=enhancement"]
body:
- type: markdown
attributes:
value: >
Filing feature requests is one of the most popular ways to contribute to Guava.


Be aware, though: most feature requests are not accepted, even if they're suggested by
a full-time Guava team member. [Feedback](https://stackoverflow.com/a/4543114) from our
users indicates that they really appreciate Guava's high power-to-weight ratio. It's
important to us to keep Guava as easy to use and understand as we can. That means boiling
features down to compact but powerful abstractions, and controlling feature bloat carefully.

- type: textarea
attributes:
label: API(s)
description: Which existing classes or methods do you want to improve?
placeholder: e.g., `com.google.common.collect.ImmutableList::of`
render: java
validations:
required: true

- type: textarea
attributes:
label: How do you want it to be improved?
validations:
required: true

- type: textarea
attributes:
label: Why do we need it to be improved?
validations:
required: true

- type: textarea
attributes:
label: Example
description: >
Please provide an example usage of the feature that would be different with the improvement.
render: java
validations:
required: true

- type: textarea
attributes:
label: Current Behavior
description: What does the feature currently do?
validations:
required: true

- type: textarea
attributes:
label: Desired Behavior
description: What do you want it to do instead?
validations:
required: true

- type: markdown
attributes:
value: >
Did you *actually* encounter the need for this enhancement in a real-world scenario, or does
it just seem like a sensible behavior for the feature to have?


Before we make significant changes to existing features in Guava, we really want to be sure
that it's for a use case that actually comes up in the real world. We want to hear the
real-world use case so the community can discuss and debate whether this feature is actually
the *best* way to address the real use case, or whether or not a different approach might be
more appropriate.


It's okay if you can't provide complete context on a use case. We understand if you are not
able to discuss the full details of what you're working on.


But Guava aims to provide functionality that is useful across boundaries of projects,
companies, or even industries &mdash; utilities useful for a sizable proportion of all Java
programmers everywhere. If you can give enough detail such that any of us can imagine coming
across a similar need in our own work, that's extremely helpful in studying how broadly
useful the proposed change will be.

- type: textarea
attributes:
label: Concrete Use Cases
description: Please provide use cases that actually came up in the real world.
validations:
required: true

- type: checkboxes
attributes:
label: Checklist
options:
- label: >
I agree to follow the
[code of conduct](https://github.com/google/.github/blob/master/CODE_OF_CONDUCT.md).
required: true
- label: >
I have read and understood the [contribution
guidelines](https://github.com/google/guava/wiki/HowToContribute#feature-requests).
required: true
- label: >
I have read and understood
[Guava's philosophy](https://github.com/google/guava/wiki/PhilosophyExplained), and
I strongly believe that this proposal aligns with it.
required: true
21 changes: 18 additions & 3 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,27 @@ updates:
# - package-ecosystem: "maven"
# directory: "/"
# schedule:
# interval: "daily"
# interval: "weekly"
# groups:
# dependencies:
# applies-to: version-updates
# patterns:
# - "*"
# - package-ecosystem: "maven"
# directory: "/android"
# schedule:
# interval: "daily"
# interval: "weekly"
# groups:
# dependencies:
# applies-to: version-updates
# patterns:
# - "*"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
interval: "weekly"
groups:
github-actions:
applies-to: version-updates
patterns:
- "*"
Loading