Suppress https://errorprone.info/bugpattern/ThrowIfUncheckedKnownUnch…

…ecked warnings. RELNOTES=n/a PiperOrigin-RevId: 702798888
scope-demo · Dec 4, 2024 · 5d6e2bd · 5d6e2bd
1 parent 8a24204
commit 5d6e2bd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/android/guava-tests/test/com/google/common/base/ThrowablesTest.java b/android/guava-tests/test/com/google/common/base/ThrowablesTest.java
@@ -55,11 +55,15 @@
 @GwtCompatible(emulated = true)
 @SuppressWarnings("deprecation") // tests of numerous deprecated methods
 public class ThrowablesTest extends TestCase {
+  // We're testing that the method is in fact equivalent to throwing the exception directly.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testThrowIfUnchecked_unchecked() {
     assertThrows(
         SomeUncheckedException.class, () -> throwIfUnchecked(new SomeUncheckedException()));
   }
 
+  // We're testing that the method is in fact equivalent to throwing the exception directly.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testThrowIfUnchecked_error() {
     assertThrows(SomeError.class, () -> throwIfUnchecked(new SomeError()));
   }
@@ -71,6 +75,8 @@ public void testThrowIfUnchecked_checked() {
 
   @J2ktIncompatible
   @GwtIncompatible // propagateIfPossible
+  // We're testing that the method is in fact equivalent to throwing the exception directly.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testPropagateIfPossible_noneDeclared_unchecked() {
     assertThrows(
         SomeUncheckedException.class, () -> propagateIfPossible(new SomeUncheckedException()));
@@ -151,12 +157,16 @@ public void testPropagateIfPossible_twoDeclared_neitherSame()
         SomeOtherCheckedException.class);
   }
 
+  // I guess it's technically a bug that ThrowIfUncheckedKnownUnchecked fires here.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testThrowIfUnchecked_null() {
     assertThrows(NullPointerException.class, () -> throwIfUnchecked(null));
   }
 
   @J2ktIncompatible
   @GwtIncompatible // propagateIfPossible
+  // I guess it's technically a bug that ThrowIfUncheckedKnownUnchecked fires here.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testPropageIfPossible_null() {
     propagateIfPossible(null);
   }

diff --git a/guava-tests/test/com/google/common/base/ThrowablesTest.java b/guava-tests/test/com/google/common/base/ThrowablesTest.java
@@ -55,11 +55,15 @@
 @GwtCompatible(emulated = true)
 @SuppressWarnings("deprecation") // tests of numerous deprecated methods
 public class ThrowablesTest extends TestCase {
+  // We're testing that the method is in fact equivalent to throwing the exception directly.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testThrowIfUnchecked_unchecked() {
     assertThrows(
         SomeUncheckedException.class, () -> throwIfUnchecked(new SomeUncheckedException()));
   }
 
+  // We're testing that the method is in fact equivalent to throwing the exception directly.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testThrowIfUnchecked_error() {
     assertThrows(SomeError.class, () -> throwIfUnchecked(new SomeError()));
   }
@@ -71,6 +75,8 @@ public void testThrowIfUnchecked_checked() {
 
   @J2ktIncompatible
   @GwtIncompatible // propagateIfPossible
+  // We're testing that the method is in fact equivalent to throwing the exception directly.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testPropagateIfPossible_noneDeclared_unchecked() {
     assertThrows(
         SomeUncheckedException.class, () -> propagateIfPossible(new SomeUncheckedException()));
@@ -151,12 +157,16 @@ public void testPropagateIfPossible_twoDeclared_neitherSame()
         SomeOtherCheckedException.class);
   }
 
+  // I guess it's technically a bug that ThrowIfUncheckedKnownUnchecked fires here.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testThrowIfUnchecked_null() {
     assertThrows(NullPointerException.class, () -> throwIfUnchecked(null));
   }
 
   @J2ktIncompatible
   @GwtIncompatible // propagateIfPossible
+  // I guess it's technically a bug that ThrowIfUncheckedKnownUnchecked fires here.
+  @SuppressWarnings("ThrowIfUncheckedKnownUnchecked")
   public void testPropageIfPossible_null() {
     propagateIfPossible(null);
   }