[pull] master from asim:master #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
asim
force-pushed
the
master
branch
2 times, most recently
from
d4c14e6 to
7136c61
Compare
* release plugins * add window plugins release bat script Co-authored-by: Johnson C <[email protected]>
I realized that when writing `require go-micro.dev/v4 v4.1.0` in the `go.mod` file, `go mod tidy` will install that exact version of `go-micro.dev/v4`. As of right now, v4.1.0 is an outdated version, and preferably we shouldn't be updating gomu's Go Modules template everytime a new release is tagged, but still want gomu users to generate projects using the latest Go Micro version. In an attempt to solve this problem, I'm opting to add a new Makefile rule for new projects generated by gomu, `update` that runs `go get -u`. This aggressively updates any dependencies your Go Modules project may have. `go mod tidy` is then able to prune the `go.mod` and `go.sum` files by removing the unnecessary checksums and transitive dependencies (e.g. `// indirect`), that were added to by go get -u due to newer semver available. Put one and one together and you get two. In addition to adding an `update` rule to the Makefile generated for new projects by gomu, I'm also updating the proto and client comments printed when new projects have been generated to promote the `update` rule. References: - https://stackoverflow.com/questions/67201708/go-update-all-modules
2. try fixing grpc plugin failed to get issue
use v4.0.0-v4.0.0-00010101000000-000000000000 instead of specific version
3. kafka panic on disconnect
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x18 pc=0x1266c50]
goroutine 31 [running]:
github.com/asim/go-micro/plugins/broker/kafka/v3.(*kBroker).Disconnect(0xc0002400c0)
C:/Workshop/Go/pkg/mod/github.com/asim/go-micro/plugins/broker/kafka/[email protected]/kafka.go:130 +0xd0
github.com/asim/go-micro/plugins/server/grpc/v3.(*grpcServer).Start.func2()
C:/Workshop/Go/pkg/mod/github.com/asim/go-micro/plugins/server/grpc/[email protected]/grpc.go:998 +0xc8d
created by github.com/asim/go-micro/plugins/server/grpc/v3.(*grpcServer).Start
C:/Workshop/Go/pkg/mod/github.com/asim/go-micro/plugins/server/grpc/[email protected]/grpc.go:917 +0xcaf
exit status 2
remove unnecessary dependencies between plugins upgrade go-micro.dev/v4 to v4.2.1
* support stream CloseSend * move CloseSend into Closer
* Rename Gomu to Micro * docs: Remove license reference in CLI's README
set the go version to 1.16 in pr.yml and tests.yml, so as to be consistent with the version in go.mod.
Co-authored-by: longhaoteng <[email protected]>
Co-authored-by: longhaoteng <[email protected]>
* add events package * update go version
* [fix] etcd config source prefix issue (#2389) * http transport data race issue (#2436) * [fix] #2431 http transport data race issue * [feature] Ability to close connection while receiving. Ability to send messages while receiving. Icreased r channel limit to 100 to more fluently communication. Do not dropp sent request if r channel is full. * [fix] Use pool connection close timeout * [fix] replace Close with private function * [fix] Do not close the transport client twice in stream connection , the transport client is closed in the rpc codec * [fix] tests --------- Co-authored-by: Johnson C <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )