[pull] develop from duckduckgo:develop #783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Task/Issue URL: https://app.asana.com/0/414709148257752/1204422898101808/f Tech Design URL: CC: Description: Modification of the Image Cache screen to display all cached favicons to accurately track that deleting bookmarks, closing tabs etc clear cached favicons correctly
Task/Issue URL: https://app.asana.com/0/0/1205344392346068/f BSK PR: duckduckgo/BrowserServicesKit#482 Description: macOS lock autofill for forms.
Task/Issue URL: https://app.asana.com/0/0/1205381133187310/f ## Related PRs BSK PR: duckduckgo/BrowserServicesKit#483 macOS PR: duckduckgo/macos-browser#1562 ## Description Integrates some of the latest changes from BSK. -------- Co-authored-by: Sam Symons <[email protected]>
Task/Issue URL: https://app.asana.com/0/0/1205407743356198/f Tech Design URL: CC: Description: This PR bumps BSK to handle the removed incremental test feature. This was never used by iOS, so this change should have no effect.
…1968) Task/Issue URL: https://app.asana.com/0/30173902528854/1205306937274017/f Description: This is to deprecate current pixel because of a possibility to skew metrics in the future after a recent anomaly.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1205398889304566/f BSK PR: duckduckgo/BrowserServicesKit#490 Description: Fixes an issue that causes passwords to be saved to local vault when Bitwarden is enabled.
Task/Issue URL: https://app.asana.com/0/414709148257752/1205415059499063 Tech Design URL: CC: Description: Adds creation and modified dates to the keychain debug screen. Steps to test this PR: Run the app and create some keychain entries (autofill, email, etc) Check the keychain debug screen shows the creation / modification dates
Task/Issue URL: https://app.asana.com/0/0/1205254652502303/f Tech Design URL: https://app.asana.com/0/481882893211075/1205248329666560/f Description: Adding SyncSettingsAdapter to handle Sync for supported settings (currently only Email Protection auth status). EmailManager notifications can now be posted from a background thread (by Sync) so their handlers in the app were updated to run always on main thread (which is required because they update UI). Sync is automatically triggered whenever Email Protection auth status change (unless the change was caused by Sync itself).
Task/Issue URL: https://app.asana.com/0/0/1205416442924463/f BSK PR: duckduckgo/BrowserServicesKit#491 macOS PR: duckduckgo/macos-browser#1588 ## Description Integrates some changes from BSK that make NetP now clear the auth token in the extension when `resetAllState` is called. Also fixes a small bugfix with a callback not being called when it should.
Task/Issue URL: https://app.asana.com/0/414709148257752/1204144513391838/f Tech Design URL: CC: Description: Fixes an edge case where tapping on the search bar caused a crashed.
Task/Issue URL: https://app.asana.com/0/1203301625297703/1205419026232021/f Description: Update PR Checks workflow so that it searches JUnit test report for failed test cases, and reports every single failed test case as new task in Asana (or a subtask in case of duplicates).
Task/Issue URL: https://app.asana.com/0/414235014887631/1205185501564329/f Tech Design URL: CC: Description: Removes Lock Screen widget pixels. Steps to test this PR: Run the app. Add some Lock Screen widgets Use them, check no pixels are sent related to their usage
Task/Issue URL: https://app.asana.com/0/414709148257752/1205435539607486/f Description: Update Autoconsent script to 6.0.0
Task/Issue URL: https://app.asana.com/0/1204099484721401/1202285063304466/f BSK PR: duckduckgo/BrowserServicesKit#477 Description: Updates the SecureVaultDelegate signature, so we can individually turn off autofill for cards, logins and identities on macOS (and on iOS later down the road).
…in screen (#2002) Task/Issue URL: https://app.asana.com/0/0/1205463416606385/f Tech Design URL: CC: Description: Applies same authentication logic check to the details screen as to it's parent
Task/Issue URL: https://app.asana.com/0/414709148257752/1205255888342957/f Tech Design URL: CC: Description: Prevent autofill from autoprompting saved long in preview tabs i.e. when long pressing on a link
Task/Issue URL: https://app.asana.com/0/414235014887631/1205185500420499/f Tech Design URL: CC: @brindy Description: This PR fixes the iOS 17 widget view. We're one beta away from GM, so I view it as unlikely that anything will improve here - to make sure we're safe, I've swapped over to a Circle view from Rectangle.
Task/Issue URL: https://app.asana.com/0/0/1205958731729756/f BSK PR: duckduckgo/BrowserServicesKit#565 macOS PR: duckduckgo/macos-browser#1858 Description Updates BSK with the latest changes.
Co-authored-by: Diego Rey Mendez <[email protected]>
Task/Issue URL: https://app.asana.com/0/0/1205949780297088/f Tech Design URL: https://app.asana.com/0/481882893211075/1204986998781220/f Description: Add BookmarksFaviconFetcher that is used to fetch favicons for bookmarks received by Sync. Fetcher is opt-in, controlled by a setting inside Sync settings (with an additional in-context onboarding popup presented from client apps). Fetcher uses LinkPresentation framework to obtain a favicon for a given domain, and in case of failure it falls back to checking hardcoded favicon URLs. Fetcher keeps a state internally, by saving list of bookmarks IDs that need processing to a file on disk. Fetcher plugs into clients' implementation of favicon storage by exposing FaviconStoring protocol. Fetcher performs fetching on a serial operation queue. Each fetcher invocation cancels previously scheduled operation and schedules a new one. Updating fetcher state is also scheduled on the operation queue - state updates don't support cancelling and always finish before next operation is started.
Co-authored-by: Shane Osbourne <[email protected]>
Task/Issue URL: https://app.asana.com/0/414235014887631/1205953072928854/f Tech Design URL: CC: Description: New pixels for iOS toolbars project. Address Bar AddressBarSettingsPressed: New pixel m_addressbar_settings AddressBarRefreshPressed: This is the m_r pixel and is only called from the address bar so already exists AddressBarShieldPressed: This is the mp pixel so already exists AddressBarSharePressed: This was one pixel with a parameter, but I'm splitting into two new ones for clarity: new pixel: m_addressbar_share from the address bar new pixel: m_browsingmenu_share from the menu pixel removed: mb_sh has been removed Share Sheet Share result New pixel m_sharesheet_result_success when success is true New pixel m_sharesheet_result_fail when success is false ShareSheetCopy: new pixel m_sharesheet_activity_copy ShareSheetAddBookmark: new pixel m_sharesheet_activity_addbookmark ShareSheetAddFavorite: new pixel m_sharesheet_activity_addfavorite ShareSheetFindinPage: new pixel m_sharesheet_activity_findinpage ShareSheetPrint: new pixel m_sharesheet_activity_print ShareSheetAddToReadingList: new pixel m_sharesheet_activity_addtoreadinglist Also includes adding app version by default to the pixels as part of privacy triage: https://app.asana.com/0/69071770703008/1206042861558143/f
Task/Issue URL: https://app.asana.com/0/0/1205948195318715/f Description: Update the sync UI flow according to https://www.figma.com/file/5wIXwQLKJ0dZVsP5XWcgbT/%F0%9F%8E%AF-Sync-9?type=design&node-id=8748-306047&mode=design&t=5IygRcQcvvNAJ7xg-0
Task/Issue URL: https://app.asana.com/0/414235014887631/1206073390175555/f Tech Design URL: CC: Description: This PR adds a row to the VPN waitlist view controller to show the T&C status, and correctly resets it when resetting all data.
Task/Issue URL: https://app.asana.com/0/0/1206056874665890/f Description: During the NetP iOS ship review, there was feedback that the server IP address labels should not feature the port. So now, rather than sending the host + port as the server address, I’m just sending the host.
Task/Issue URL: https://app.asana.com/0/0/1206027185389966/f Tech Design URL: CC: Description: This PR makes some final touches for the NetP waitlist, including: Adding RMF support Adding pixels Updates NetP to only be visible to US users (unless they're internal) Recording the date at which the user activated NetP, in order to show messages remotely if necessary
1. Introduce maestro test flows for address bar spoofing. 2. Update the omnibar text value to "about:blank" when a file download prompt is shown.
Task/Issue URL: https://app.asana.com/0/0/1205884549503153/f Description: Improve handling of lists in syncable models' payloads (which currently is limited to bookmarks folders and favorites folders children). This change updates how lists are sent to Sync in PATCH payloads by including current state as well as the set of removed and inserted items. To allow for this, last sync payload is kept for all bookmarks folders in lastChildrenPayloadReceivedFromSync property added on BookmarkEntity entity. If the payload is not available (e.g. first sync), the legacy mechanism is used (i.e. sending only the current contents of the list). The schema of a Sync response payload does not change so the implementation handles it too.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206100276423377/f Tech Design URL: CC: Description: This PR updates BSK to include a NetP settings change. The change isn't used here in any way.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1205692741026215/f Tech Design URL: https://app.asana.com/0/1205842942115003/1205917507991804/f **Description**: This PR introduces a new version of BSK (PR: duckduckgo/BrowserServicesKit#578) that allows iOS and macOS to share the same web implementation of the `ReportBrokenSite` page and introduce improvements to Pixels and the broken site report data. Additional changes - The old native `Report broken site` page has been removed - Added 2 new Pixels https://app.asana.com/0/1205842942115003/1205859726054342/f - Removed legacy PrivacyDashboard.storyboard localised strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )