[pull] master from Alamofire:master #417
Open
+85,090
−17,636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* adding more flexibility in reusing RetryPolicy * running swift format * changing the concept from reusable static helper methods to overridable `RetryPolicy` instance methods * removing `ConditionalRetrier` and disallowing override of the delay calculation * Update doc comment, code formatting. Co-authored-by: Jon Shier <[email protected]>
* Fix stream vs. completion sequence issues. * Refactor tests for greater detail. * Test changes for reliability. * Reenable challenge events. * Instead of requeuing, store and then execute completions.
* Disable redirect tests due to HTTPBin issue. * Formatting.
* Add more detail, better formatting to debugDescription. * Extraneous formatting.
* Add CFNetwork as an explicitly linked framework for Apple platforms. * Updated formatting.
* Version to 5.2.2. * Update Jazzy docs.
* Grammtically updated the READ.me * Update README.md Co-authored-by: Jon Shier <[email protected]> * Update README.md Co-authored-by: Jon Shier <[email protected]> * Update README.md Co-authored-by: Jon Shier <[email protected]> Co-authored-by: Jon Shier <[email protected]>
* feat (Response) : add info for debugDescription add parameters info for debugDescription of DataResponse and DownloadResponse * refactor (Response) : update * feat (Response) : add Response Body for debugDescription * merge from Alamofire master * style (iOS Example) : update style * refactor (MasterViewController) : remove an unused property * refactor (DetailViewController) : indexPath NSIndexPath -> IndexPath * refactor (iOS Example) : update Main.storyboard * refactor (DetailViewController) : indexPath NSIndexPath -> IndexPath * Revert "style (iOS Example) : update style" * refactor (DetailViewController) : indexPath NSIndexPath -> IndexPath * Revert "refactor (iOS Example) : update Main.storyboard" This reverts commit 5d46504.
* Update to Xcode 11.6, add Swift 5.3 and iOS 14 builds. * Disable iOS 14 tests until Combine issues are fixed.
* Skip specific cancellation tests on 2020 OSes. * Reenable testing on iOS 14. * Only build for Swift 5.1, don’t test.
…efaultHTTPHeaders` to `headers` (#3292)
* Update to Xcode 12 build settings, standardize. * Update to Xcode 12 for CI.
…path fails. (#3306) * Fix to throw an error in MultipartUpload when copying a file to a temporary path fails. * Update UploadMultipartFormDataTest for nonexistent file.
Removed an extra space
* Add additional lifetime closures. * Update formatting. * Add documentation on the new lifetime methods.
* Fix crash when download local file * Clean up tests. Co-authored-by: Jon Shier <[email protected]>
* Fix double lock in AuthenticationInterceptor. * Refactor test name. * Get rid of additional Xcode checks.
* Version to 5.3.0. * Apply the latest formatting from SwiftFormat. * Update Gems. * Update Jazzy docs.
* Remove file URL error, add support for downloads. * Add documentation note about file downloads.
### Issue Link 🔗 [Apple's update to their API policy - Required Reason](#3761) ### Goals ⚽ To comply with Apple's new privacy policies every app and third-party SDK should include a Privacy manifest in case if they access APIs which potentially can be used for fingerprinting. All use cases of such API require explicit reasons declaration. Alamofire accesses `systemUptime` property which is included in a required reasons API. ### Implementation Details 🚧 - Added a PrivacyInfo.xcprivacy file. The file requires all four fields to be included: - SDK does not use tracking; - Tracking domains array is empty. It can be empty as long as tracking is false; - SDK does not collect any data. NSPrivacyCollectedDataTypes is empty; - SDK uses `systemUptime`, Reason: [35F9.1: Measure time on-device, per documentation](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api#4278394) - Updated package.swift file to include the privacy manifest to the SP. ### Testing Details 🔍 Not applicable
### Goals ⚽ The privacy manifest implementation from #3792 was incorrect (thought I had checked it) and breaks the package. This fixes the packages and adds the manifest to the raw framework targets as well.
### Goals ⚽ - Remove duplicate rules - isEmpty - wrapMultilineStatementBraces - Merge the rules that are split into two parts into one - andOperator - Sort disable rules alphabetically
Maintain consistency in the doc like here: https://github.com/Alamofire/Alamofire/blob/5c68811d8b1eb4ac312a3968fa54e88a31a33abc/Source/Features/AuthenticationInterceptor.swift#L27 Signed-off-by: hugo-syn <[email protected]>
### Goals ⚽ <!-- List the high-level objectives of this pull request. --> <!-- Include any relevant context. --> - Fix typos in the quick help of `Request.swift`, `ResponseSerialization.swift`, `ServerTrustEvaluation.swift`, `URLEncodedFormEncoder.swift` ### Implementation Details 🚧 <!-- Explain the reasoning behind any architectural changes. --> <!-- Highlight any new functionality. --> 1. `Request.swift` -> `isResumed` |before|after| |--|--| |<img width="350" src="https://github.com/Alamofire/Alamofire/assets/51712973/8a5b9abf-2d66-460d-b831-d5d9ce3f48f9">|<img width="350" src="https://github.com/Alamofire/Alamofire/assets/51712973/68797322-15aa-4ba2-896f-75b3bb757720">| 2. `ResponseSerialization.swift` -> `responseAllowsEmptyResponseData(_:)` |before|after| |--|--| |<img width="350" src="https://github.com/Alamofire/Alamofire/assets/51712973/ceb68e06-19bb-4f3a-a8fa-261fdf646d9f">|<img width="350" src="https://github.com/Alamofire/Alamofire/assets/51712973/4cd98ceb-8de9-4cab-9879-969453536a4f">| 3. `ServerTrustEvaluation.swift` -> `AlamofireExtension` -> `isSuccess` |before|after| |--|--| |<img width="350" src="https://github.com/Alamofire/Alamofire/assets/51712973/aa5ca255-9893-48bc-8a4d-e77a9735eb40">|<img width="350" src="https://github.com/Alamofire/Alamofire/assets/51712973/43180633-4019-47c1-8556-e9ed2610426e">| 4. `URLEncodedFormEncoder.swift` -> `encode(_:)` |before|after| |--|--| |<img width="350" src="https://github.com/Alamofire/Alamofire/assets/51712973/44f0b62f-83c3-4bdf-a126-37a436eef10d">|<img width="350" src="https://github.com/Alamofire/Alamofire/assets/51712973/b3fee803-6bbd-4aca-941e-1551d99f565f">| ### Testing Details 🔍 <!-- Describe what tests you've added for your changes. --> No testing is needed as the change is in the comment.
### Goals ⚽ This PR adds the final support for PrivacyInfo through CocoaPods.
### Goals ⚽ This PR prepares the 5.9.0 release.
### Issue Link 🔗 #3844 ### Goals ⚽ Adds the ability to use Alamofire with Cocoapods on visionOS. ### Implementation Details 🚧 As `visionos` was introduced in Cocoapods 1.13.0, the minimum required version was bumped as well. ### Testing Details 🔍 N/A
### Goals ⚽ Just like the #3816 but for `HTTPMethod`.
### Goals ⚽ Similar to `HTTPMethod` in #3848, `HTTPHeaders` is trivially `Sendable`, so add the conformance (and others). ### Implementation Details 🚧 Explicitly declared conformances. ### Testing Details 🔍 No additional tests, conformances are synthesized.
### Goals ⚽ This PR prepares the 5.9.1 release.
…lendar mismatches with expected result (#3858) ### Goals ⚽ Currently test function `testThatDatesCanBeEncodedAsFormatted` fails when trying to run tests from simulator that is not using Gregorian calendar while the assertion is expecting date in Gregorian format. The goal should be running tests passed for all simulator calendar settings. ### Implementation Details 🚧 Force `DateFormatter` in the test function `testThatDatesCanBeEncodedAsFormatted` to be Gregorian so that it will be run tests passed for all simulator calendar settings.
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.6 to 3.2.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/releases">rexml's releases</a>.</em></p> <blockquote> <h2>REXML 3.2.8 - 2024-05-16</h2> <h3>Fixes</h3> <ul> <li>Suppressed a warning</li> </ul> <h2>REXML 3.2.7 - 2024-05-16</h2> <h3>Improvements</h3> <ul> <li> <p>Improve parse performance by using <code>StringScanner</code>.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/106">GH-106</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/107">GH-107</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/108">GH-108</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/109">GH-109</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/112">GH-112</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/113">GH-113</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/114">GH-114</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/115">GH-115</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/116">GH-116</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/117">GH-117</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/118">GH-118</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/119">GH-119</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/121">GH-121</a></p> </li> <li> <p>Patch by NAITOH Jun.</p> </li> </ul> </li> <li> <p>Improved parse performance when an attribute has many <code><</code>s.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/124">GH-124</a></li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>XPath: Fixed a bug of <code>normalize_space(array)</code>.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/110">GH-110</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/111">GH-111</a></p> </li> <li> <p>Patch by flatisland.</p> </li> </ul> </li> <li> <p>XPath: Fixed a bug that wrong position is used with nested path.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/110">GH-110</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/122">GH-122</a></p> </li> <li> <p>Reported by jcavalieri.</p> </li> <li> <p>Patch by NAITOH Jun.</p> </li> </ul> </li> <li> <p>Fixed a bug that an exception message can't be generated for invalid encoding XML.</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p> <blockquote> <h2>3.2.8 - 2024-05-16 {#version-3-2-8}</h2> <h3>Fixes</h3> <ul> <li>Suppressed a warning</li> </ul> <h2>3.2.7 - 2024-05-16 {#version-3-2-7}</h2> <h3>Improvements</h3> <ul> <li> <p>Improve parse performance by using <code>StringScanner</code>.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/106">GH-106</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/107">GH-107</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/108">GH-108</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/109">GH-109</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/112">GH-112</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/113">GH-113</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/114">GH-114</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/115">GH-115</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/116">GH-116</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/117">GH-117</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/118">GH-118</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/119">GH-119</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/121">GH-121</a></p> </li> <li> <p>Patch by NAITOH Jun.</p> </li> </ul> </li> <li> <p>Improved parse performance when an attribute has many <code><</code>s.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/124">GH-124</a></li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>XPath: Fixed a bug of <code>normalize_space(array)</code>.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/110">GH-110</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/111">GH-111</a></p> </li> <li> <p>Patch by flatisland.</p> </li> </ul> </li> <li> <p>XPath: Fixed a bug that wrong position is used with nested path.</p> <ul> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/110">GH-110</a></p> </li> <li> <p><a href="https://redirect.github.com/ruby/rexml/issues/122">GH-122</a></p> </li> <li> <p>Reported by jcavalieri.</p> </li> <li> <p>Patch by NAITOH Jun.</p> </li> </ul> </li> <li> <p>Fixed a bug that an exception message can't be generated for</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ruby/rexml/commit/1cf37bab79d61d6183bbda8bf525ed587012b718"><code>1cf37ba</code></a> Add 3.2.8 entry</li> <li><a href="https://github.com/ruby/rexml/commit/b67081caa807fad48d31983137b7ed8711e7f0df"><code>b67081c</code></a> Remove an unused variable (<a href="https://redirect.github.com/ruby/rexml/issues/128">#128</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/94e180e939baff8f7e328a287bb96ebbd99db6eb"><code>94e180e</code></a> Suppress a warning</li> <li><a href="https://github.com/ruby/rexml/commit/d574ba5fe1c40adbafbf16e47533f4eb32b43e60"><code>d574ba5</code></a> ci: install only gems required for running tests (<a href="https://redirect.github.com/ruby/rexml/issues/129">#129</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/4670f8fc187c89d0504d027ea997959287143453"><code>4670f8f</code></a> Add missing Thanks section</li> <li><a href="https://github.com/ruby/rexml/commit/9ba35f9f032c07c39b8c86536ac13a9cb313bef2"><code>9ba35f9</code></a> Bump version</li> <li><a href="https://github.com/ruby/rexml/commit/085def07425561862d8329001168d8bc9c75ae8f"><code>085def0</code></a> Add 3.2.7 entry</li> <li><a href="https://github.com/ruby/rexml/commit/4325835f92f3f142ebd91a3fdba4e1f1ab7f1cfb"><code>4325835</code></a> Read quoted attributes in chunks (<a href="https://redirect.github.com/ruby/rexml/issues/126">#126</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/e77365e2d1c9cdb822c7e09b05fc5a4903d92c23"><code>e77365e</code></a> Exclude older than 2.6 on macos-14</li> <li><a href="https://github.com/ruby/rexml/commit/bf2c8edb5facb206c25a62952aa37218793283e6"><code>bf2c8ed</code></a> Move development dependencies to Gemfile (<a href="https://redirect.github.com/ruby/rexml/issues/124">#124</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ruby/rexml/compare/v3.2.6...v3.2.8">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Alamofire/Alamofire/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
### Issue Link 🔗 Fixes #3878 ### Goals ⚽ This PR ensures the queue for `responseStreamDecodable` is properly passed to the underlying serializer. ### Testing Details 🔍 Tests added for methods on arbitrary queues.
…3882) ### Goals ⚽ Update links for repositories moved to the swiftlang org on GitHub. Update the link + https://github.com/apple/swift/ => https://github.com/swiftlang/swift/ This appears on production at + https://alamofire.github.io/Alamofire/Classes/URLEncodedFormEncoder/KeyEncoding.html => [JSONEncoder‘s KeyEncodingStrategy]
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.8 to 3.3.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/releases">rexml's releases</a>.</em></p> <blockquote> <h2>REXML 3.3.6 - 2024-08-22</h2> <h3>Improvements</h3> <ul> <li> <p>Removed duplicated entity expansions for performance.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/194">GH-194</a></li> <li>Patch by Viktor Ivarsson.</li> </ul> </li> <li> <p>Improved namespace conflicted attribute check performance. It was too slow for deep elements.</p> <ul> <li>Reported by l33thaxor.</li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>Fixed a bug that default entity expansions are counted for security check. Default entity expansions should not be counted because they don't have a security risk.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/198">GH-198</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/199">GH-199</a></li> <li>Patch Viktor Ivarsson</li> </ul> </li> <li> <p>Fixed a parser bug that parameter entity references in internal subsets are expanded. It's not allowed in the XML specification.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/191">GH-191</a></li> <li>Patch by NAITOH Jun.</li> </ul> </li> <li> <p>Fixed a stream parser bug that user-defined entity references in text aren't expanded.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/200">GH-200</a></li> <li>Patch by NAITOH Jun.</li> </ul> </li> </ul> <h3>Thanks</h3> <ul> <li> <p>Viktor Ivarsson</p> </li> <li> <p>NAITOH Jun</p> </li> <li> <p>l33thaxor</p> </li> </ul> <h2>REXML 3.3.5 - 2024-08-12</h2> <h3>Fixes</h3> <ul> <li>Fixed a bug that <code>REXML::Security.entity_expansion_text_limit</code> check has wrong text size calculation in SAX and pull parsers. <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/193">GH-193</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/195">GH-195</a></li> <li>Reported by Viktor Ivarsson.</li> <li>Patch by NAITOH Jun.</li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p> <blockquote> <h2>3.3.6 - 2024-08-22 {#version-3-3-6}</h2> <h3>Improvements</h3> <ul> <li> <p>Removed duplicated entity expansions for performance.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/194">GH-194</a></li> <li>Patch by Viktor Ivarsson.</li> </ul> </li> <li> <p>Improved namespace conflicted attribute check performance. It was too slow for deep elements.</p> <ul> <li>Reported by l33thaxor.</li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>Fixed a bug that default entity expansions are counted for security check. Default entity expansions should not be counted because they don't have a security risk.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/198">GH-198</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/199">GH-199</a></li> <li>Patch Viktor Ivarsson</li> </ul> </li> <li> <p>Fixed a parser bug that parameter entity references in internal subsets are expanded. It's not allowed in the XML specification.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/191">GH-191</a></li> <li>Patch by NAITOH Jun.</li> </ul> </li> <li> <p>Fixed a stream parser bug that user-defined entity references in text aren't expanded.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/200">GH-200</a></li> <li>Patch by NAITOH Jun.</li> </ul> </li> </ul> <h3>Thanks</h3> <ul> <li> <p>Viktor Ivarsson</p> </li> <li> <p>NAITOH Jun</p> </li> <li> <p>l33thaxor</p> </li> </ul> <h2>3.3.5 - 2024-08-12 {#version-3-3-5}</h2> <h3>Fixes</h3> <ul> <li>Fixed a bug that <code>REXML::Security.entity_expansion_text_limit</code> check has wrong text size calculation in SAX and pull parsers. <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/193">GH-193</a></li> <li><a href="https://redirect.github.com/ruby/rexml/issues/195">GH-195</a></li> <li>Reported by Viktor Ivarsson.</li> <li>Patch by NAITOH Jun.</li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ruby/rexml/commit/95871f399eda642a022b03550479b7994895c742"><code>95871f3</code></a> Add 3.3.6 entry</li> <li><a href="https://github.com/ruby/rexml/commit/7cb5eaeb221c322b9912f724183294d8ce96bae3"><code>7cb5eae</code></a> parser tree: improve namespace conflicted attribute check performance</li> <li><a href="https://github.com/ruby/rexml/commit/6109e0183cecf4f8b587d76209716cb1bbcd6bd5"><code>6109e01</code></a> Fix a bug that Stream parser doesn't expand the user-defined entity reference...</li> <li><a href="https://github.com/ruby/rexml/commit/cb158582f18cebb3bf7b3f21f230e2fb17d435aa"><code>cb15858</code></a> parser: keep the current namespaces instead of stack of Set</li> <li><a href="https://github.com/ruby/rexml/commit/2b47b161db19c38c5e45e36c2008c045543e976e"><code>2b47b16</code></a> parser: move duplicated end tag check to BaseParser</li> <li><a href="https://github.com/ruby/rexml/commit/35e1681a179c28d5b6ec97d4ab1c110e5ac00303"><code>35e1681</code></a> test tree-parser: move common method to base class</li> <li><a href="https://github.com/ruby/rexml/commit/6e00a14daf2f901df535eafe96cc94d43a957ffe"><code>6e00a14</code></a> test: fix indent</li> <li><a href="https://github.com/ruby/rexml/commit/df3a0cc83013f3cde7b7c2044e3ce00bcad321cb"><code>df3a0cc</code></a> test: fix indent</li> <li><a href="https://github.com/ruby/rexml/commit/fdbffe744b38811be8b1cf6a9eec3eea4d71c412"><code>fdbffe7</code></a> Use loop instead of recursive call for Element#namespace</li> <li><a href="https://github.com/ruby/rexml/commit/6422fa34494fd4145d7bc68fbbe9525d42becf62"><code>6422fa3</code></a> Use loop instead of recursive call for Element#root</li> <li>Additional commits viewable in <a href="https://github.com/ruby/rexml/compare/v3.2.8...v3.3.6">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Alamofire/Alamofire/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
### Goals ⚽ Fix some typos. ### Testing Details 🔍 Installed firewalk, started it and ran `swift test` - tests passing.
…ad-Safety (#3894) ### Issue Link 🔗 #3635, #3667 ### Goals ⚽ This PR attempts to fix unreproducible `CompositeEventMonitor` crashes in two ways: 1. Passing `[]` to the `Session` inits now creates a `CompositeEventMonitor` that's properly empty rather than always including an `AlamofireNotifications` monitor. This should allow anyone seeing this crash to empty out the monitors to see if the crash is resolved. **Technically this is a breaking change** as anyone passing `[]` currently has notification support. This should be rare, and this fix is important enough to justify breaking that non-obvious usage. 2. The stored monitors in the `CompositeEventMonitor` are now protected and accessed through a lock, so should be made safer. Of course, I could never figure out how any access there could be unsafe since it should always be accessed on the serial internal queue, so we'll see if that helps anything. ### Implementation Details 🚧 `Session` init updated, lock added. ### Testing Details 🔍 No tests added, test suite passes.
### Goals ⚽ Resolve `existential-any` build errors. ### Implementation Details 🚧 Added `any` to each protocols. https://github.com/swiftlang/swift-evolution/blob/main/proposals/0335-existential-any.md Co-authored-by: Jon Shier <[email protected]>
### Goals ⚽ This PR tracks the implementation of full concurrency checking when building in Swift 6 mode. It's unknown whether all of these changes will be fully backward compatible. ### Implementation Details 🚧 This PR largely consists of `Sendable` annotations, with a few logic changes to fix actual safety issues. ### Testing Details 🔍 Tests updated with needed annotations, but mutation warnings need a larger overall refactor.
### Issue Link 🔗 An alternate take on #3888. ### Goals ⚽ This PR modifies `DownloadRequest` validation to read the file size from disk, rather than reading the whole file. This prevents large memory spikes when using downloads. ### Implementation Details 🚧 Rather than reading the `Data`, validation now reads the `.fileSizeKey` resource value. ### Testing Details 🔍 No new tests, existing tests pass.
### Goals ⚽ This PR prepares the 5.10 release.
### Goals ⚽ After upgrading to version 5.10.0, the following error occurred, so I tried to fix it with this PR.  ### Environments - Xcode: 16.0 - Swift: 6.0 - Strict Concurrency Checking: Complete
### Issue Link 🔗 #3902 ### Goals ⚽ This PR relaxes the `Sendable` requirement in the value returned from `JSONResponseSerialization`, as it breaks downstream consumers still using `Any`. ### Implementation Details 🚧 Reverted the type returned from `JSONResponseSerializer` from `any Any & Sendable` to just `Any`. ### Testing Details 🔍 Tests updated.
### Goals ⚽ This PR prepares the 5.10.1 release.
### Issue Link 🔗 Fixes #3908 ### Goals ⚽ This PR fixes the deprecation in the Package.swift file.
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.8 to 3.3.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/releases">rexml's releases</a>.</em></p> <blockquote> <h2>REXML 3.3.9 - 2024-10-24</h2> <h3>Improvements</h3> <ul> <li>Improved performance. <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/210">GH-210</a></li> <li>Patch by NAITOH Jun.</li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>Fixed a parse bug for text only invalid XML.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/215">GH-215</a></li> <li>Patch by NAITOH Jun.</li> </ul> </li> <li> <p>Fixed a parse bug that <code>&#0x...;</code> is accepted as a character reference.</p> </li> </ul> <h3>Thanks</h3> <ul> <li>NAITOH Jun</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p> <blockquote> <h2>3.3.9 - 2024-10-24 {#version-3-3-9}</h2> <h3>Improvements</h3> <ul> <li>Improved performance. <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/210">GH-210</a></li> <li>Patch by NAITOH Jun.</li> </ul> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>Fixed a parse bug for text only invalid XML.</p> <ul> <li><a href="https://redirect.github.com/ruby/rexml/issues/215">GH-215</a></li> <li>Patch by NAITOH Jun.</li> </ul> </li> <li> <p>Fixed a parse bug that <code>&#0x...;</code> is accepted as a character reference.</p> </li> </ul> <h3>Thanks</h3> <ul> <li>NAITOH Jun</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ruby/rexml/commit/38eaa86ac7abe0d31cf49d8df57ad239fdeb80e9"><code>38eaa86</code></a> Add 3.3.9 entry</li> <li><a href="https://github.com/ruby/rexml/commit/ce59f2eb1aeb371fe1643414f06618dbe031979f"><code>ce59f2e</code></a> parser: fix a bug that &#0x...; is accepted as a character reference</li> <li><a href="https://github.com/ruby/rexml/commit/a09646d395a07399cbf9bc3bc8d6d8bb1d13ecea"><code>a09646d</code></a> test: fix indent</li> <li><a href="https://github.com/ruby/rexml/commit/cf0fb9c9ca3dc0d725c8e4644aa0e728025f42ce"><code>cf0fb9c</code></a> Fix <code>IOSource#readline</code> for <code>@pending_buffer</code> (<a href="https://redirect.github.com/ruby/rexml/issues/215">#215</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/1d0c362526f6e25e2abcd13e2fcefcc718c20e78"><code>1d0c362</code></a> Optimize <code>IOSource#read_until</code> method (<a href="https://redirect.github.com/ruby/rexml/issues/210">#210</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/622011f25ac1519fd553d6c56da52d7eba14a787"><code>622011f</code></a> Bump version</li> <li>See full diff in <a href="https://github.com/ruby/rexml/compare/v3.3.8...v3.3.9">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/Alamofire/Alamofire/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
### Issue Link 🔗 Fixes #3919 ### Goals ⚽ This PR makes the validation system `Sendable`, fixing a runtime crash when the consuming app is built in Swift 6 mode. ### Implementation Details 🚧 Adds `@Sendable` to the validation closures, and ensures the returned `Error` is actually `Error & Sendable`. ### Testing Details 🔍 No additional tests.
### Goals ⚽ This PR prepares the 5.10.2 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )