Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline using exceptions #8

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Inline using exceptions #8

wants to merge 7 commits into from

Conversation

scnerd
Copy link
Owner

@scnerd scnerd commented May 4, 2018

No description provided.

@ghost
Copy link

ghost commented May 4, 2018

DeepCode found the following issues:

Critical: 0
Warning: 0
Info: 0

Priority breakdown:

Security Defect API Anomaly Rename Lint Info
Critical 0 0 0 0 0 0 0
Warning 0 0 0 0 0 0 0
Info 0 0 0 0 0 0 0

Most affected files:

File Critical Warning Info

See detailed analysis.

@coveralls
Copy link

coveralls commented May 4, 2018

Pull Request Test Coverage Report for Build 77

  • 100 of 121 (82.64%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.3%) to 83.838%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pragma/core/transformer.py 9 15 60.0%
pragma/inline.py 87 102 85.29%
Files with Coverage Reduction New Missed Lines %
pragma/core/resolve/literal.py 1 85.96%
pragma/lift.py 1 96.46%
pragma/core/resolve/init.py 2 81.77%
pragma/core/transformer.py 5 77.78%
Totals Coverage Status
Change from base Build 70: -1.3%
Covered Lines: 1053
Relevant Lines: 1256

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 75

  • 100 of 121 (82.64%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.1%) to 83.997%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pragma/core/transformer.py 9 15 60.0%
pragma/inline.py 87 102 85.29%
Files with Coverage Reduction New Missed Lines %
pragma/core/resolve/literal.py 1 85.96%
pragma/core/transformer.py 5 77.78%
Totals Coverage Status
Change from base Build 70: -1.1%
Covered Lines: 1055
Relevant Lines: 1256

💛 - Coveralls

@scnerd
Copy link
Owner Author

scnerd commented May 4, 2018

This should really support the option to inline as either a for loop OR as an exception, since there are advantages/disadvantages to each.

@ghost
Copy link

ghost commented May 4, 2018

DeepCode found the following issues:

Critical: 0
Warning: 0
Info: 0

Priority breakdown:

Security Defect API Anomaly Rename Lint Info
Critical 0 0 0 0 0 0 0
Warning 0 0 0 0 0 0 0
Info 0 0 0 0 0 0 0

Most affected files:

File Critical Warning Info

See detailed analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants