-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Named attributes #15
Open
atait
wants to merge
13
commits into
scnerd:master
Choose a base branch
from
atait:feature/name-attributes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Works on any type of object so long as name, attribute, and result are literals - notable case: namedtuples
fixes the messy merge
- so lists/tuples get to keep abc.Sequence semantics - meaning enumerate is now supported
DeepCode's analysis on #79fc9b found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Pull Request Test Coverage Report for Build 116
💛 - Coveralls |
One edge case is when a user subclasses tuple directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #13
support for attribute access of user-defined classes
If it has the attribute and it is a literal, collapse the get attribute
Unrolling and deindexing
namedtuple
Support for enumerate
Before, this only worked for sequences of literals. Now it can combine with deindexing of heterogeneous sequences. It must be in this order of decoration