Update Dockerfile.rhel8 to fix the postgresql upgrade issue from v12 to v13. #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to test postgresql upgrade to version 13 from version 12 using RHEL8 based image but it's not working. I see the following env is missing in RHEL8 based postgresql 13 image POSTGRESQL_PREV_VERSION=12 Here is the link to problematic Dockerfile. https://github.com/sclorg/postgresql-container/blob/generated/13/Dockerfile.rhel8 The same works fine with RHEL7 and other images.
|
[test-all] |
phracek
requested changes
Jul 18, 2022
| @@ -11,6 +11,7 @@ FROM ubi8/s2i-core | |||
| # PostgreSQL administrative account | |||
|
|
|||
| ENV POSTGRESQL_VERSION=13 \ | |||
| POSTGRESQL_PREV_VERSION=12 \ | |||
There was a problem hiding this comment.
The valid code for fixing this is here: https://github.com/sclorg/postgresql-container/blob/master/src/Dockerfile#L14
Please do the following steps.
- fix file src/Dockerfile
- commit the change.
- The sources are generated automatically.
There was a problem hiding this comment.
Updated this file and created the new PR #456. Thanks for pointing out.
|
Closing in favor of #456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to test postgresql upgrade to version 13 from version 12 using RHEL8 based image but it's not working. I see the following env is missing in RHEL8 based postgresql 13 image
POSTGRESQL_PREV_VERSION=12
Here is the link to problematic Dockerfile.
https://github.com/sclorg/postgresql-container/blob/generated/13/Dockerfile.rhel8
The same works fine with RHEL7 and other images.