Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load ini SQL files from /docker-entrypoint-initdb.d if any (for 10.1 in a first time) #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mguillem
Copy link

@mguillem mguillem commented Aug 11, 2017

This change adds the possibility to provide ini SQL files in /docker-entrypoint-initdb.d (only for 10.1 in a first time). This is really useful to provide images with an initial state for a test or QA environment.

The patch is deeply inspired from the official mysql docker image. Supporting exactly the same startup features would be really great. See "Initializing a fresh instance" in https://hub.docker.com/_/mysql/
or here for the sources
https://github.com/docker-library/mysql/blame/dc60c4b80f3eb5b7ef8b9ae09f16f6fab7a2fbf5/8.0/docker-entrypoint.sh#L177

This is similar to my pull request for mysql-container: sclorg/mysql-container#185

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@omron93
Copy link
Contributor

omron93 commented Aug 11, 2017

Hi,
thanks for this PR.

There is a long waiting PR to add support for extending this image using s2i tool .Please take a look at #32 . It uses only different path for extending stuff - /opt/app-root/src/. It now supports only *.sh scripts, but IMPOV can be easily extended to do the same.

It would be great to use s2i compatible location to make this image "compatible" with other sclorg/ images. @mguillem So please take a look in mentioned PR if generally it could be fine for you and there is no problem with different location.

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

6 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-automation
Copy link

Can one of the admins verify this patch?

Copy link

github-actions bot commented Nov 5, 2024

Pull Request validation

Failed

🔴 Review - Missing review from a member (2 required)

Success

🟢 CI - All checks have passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants