Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added correct Stegosaurus #88

Merged
merged 3 commits into from
Oct 11, 2024
Merged

added correct Stegosaurus #88

merged 3 commits into from
Oct 11, 2024

Conversation

schochastics
Copy link
Contributor

Description

I noticed that the dinosaur you display as a stegosaurus is actually a diplodocus (potentially also a brontosaurus, Ross Geller could probably identify it properly). I really don't want cowsay to be held responsible for spreading misinformation about dinosaurs! So this PR changes the diplodocus to an actual stegosaurus.

Related Issue

Example

say(what = "test",by = "stegosaurus")
#>
#> ------ 
#>test 
#> ------ 
#> \   
#>  \  
#>   \
#>                         .       .
#>                        / `.   .' \
#>                .---.  <    > <    >  .---.
#>                |    \  \ - ~ ~ - /  /    |
#>                 ~-..-~             ~-..-~
#>             \~~~\.'                    `./~~~/
#>   .-~~^-.    \__/                        \__/
#> .'  O    \     /               /       \  \
#>(_____,    `._.'               |         }  \/~~~/
#> `----.          /       }     |        /    \__/
#>       `-.      |       /      |       /      `. ,~~|
#>           ~-.__|      /_ - ~ ^|      /- _      `..-'   f: f:
#>                |     /        |     /     ~-.     `-. _||_||_
#>                |_____|        |_____| 

@sckott sckott added this to the v1.0 milestone Oct 10, 2024
@sckott
Copy link
Owner

sckott commented Oct 10, 2024

thanks @schochastics Looks good. And I agree that was not a stegosaurus.

LGTM

want to be added as a ctb or no? https://github.com/sckott/cowsay/blob/main/DESCRIPTION#L13-L26

@schochastics
Copy link
Contributor Author

thanks @sckott. I added myself as a contributor

@sckott
Copy link
Owner

sckott commented Oct 11, 2024

great, thanks. many thanks for the contribution! will be in next cran release, but not sure when that will be. want to solve #67 first before that release

@sckott sckott merged commit fb39244 into sckott:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants