Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize tests #62

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Dockerize tests #62

wants to merge 10 commits into from

Conversation

ryansanford
Copy link
Contributor

@ryansanford ryansanford commented Jun 8, 2017

Here's the skeleton for dockerized tests for review tomorrow.

Things I'm explicitly seeking buy-in on. not married to existing implementation, but wanted to do something for sake of discussion:

  • TEST_ARGS pass-through options for docker/test.sh to test/bin/test.sh
  • Cache orthanc docker image. (45s on travis with no caching)
  • level of input validation appropriate. I'd prefer more extensive
  • location of docker/test.sh. This still feels awkward to me. If I'm new to a repo, I expect to find test convience scripts in test/bin. Maybe this is wrong and I need to get over this?
  • WIP...

@ryansanford
Copy link
Contributor Author

@gsfr Heads up

@gsfr
Copy link
Member

gsfr commented Jun 9, 2017

@ryansanford Per offline discussion, please minimize orthanc-config.json and rename test directory to tests to avoid bash keyword conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants