Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 401 Error Logging #200

Merged
merged 5 commits into from
Mar 16, 2016
Merged

Improve 401 Error Logging #200

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c646f7
Add request headers to 401 OAuth token error
nagem Mar 14, 2016
84c32b3
Remove unused pprint import
nagem Mar 14, 2016
943b8a0
Remove auth token from log message
nagem Mar 16, 2016
2be19b8
Keep auth token in log message
nagem Mar 16, 2016
4274d63
Improved method of printing dict
nagem Mar 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions api/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ def __init__(self, request=None, response=None):
u = u._replace(query=urllib.urlencode(query, True))
provider_avatar = urlparse.urlunparse(u)
else:
headers = {'WWW-Authenticate': 'Bearer realm="{}", error="invalid_token", error_description="Invalid OAuth2 token."'.format(site_id)}
self.abort(401, 'invalid oauth2 token', headers=headers)
err_msg = 'Invalid OAuth2 token.'
headers = {'WWW-Authenticate': 'Bearer realm="{}", error="invalid_token", error_description="{}"'.format(site_id, err_msg)}
log.warn('{} Request headers: {}'.format(err_msg, str(self.request.headers.items())))
self.abort(401, err_msg, headers=headers)

# 'Debug' (insecure) setting: allow request to act as requested user
elif self.debug and self.get_param('user'):
Expand Down