Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle replacing of files, rerun jobs when file is replaced #1082

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nagem
Copy link
Contributor

@nagem nagem commented Feb 21, 2018

Closes #878
Closes #1081

Test fixes and additions yet to come

@nagem nagem requested review from ambrussimon and kofalt February 21, 2018 22:23
@nagem
Copy link
Contributor Author

nagem commented Feb 21, 2018

@gsfr How this affects the reaper:

If a reaper (or anything) sends a file to a container with the same filename:

  • If the file object is the same (via hash), the existing file object in the file system and in mongo is unchanged. The file update is ignored.
  • If the file object has a different hash, the existing file object is removed from Mongo and a new file is added to Mongo with metadata specified on that upload. All new jobs resulting from rules are run, as well as all old jobs that had this file as input.

Let me know if this is contrary to what you'd expect.

@gsfr gsfr removed request for kofalt and ambrussimon May 11, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant