Edits due to reviewers comments. #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| hyper-parameters can be changed by changing instance variables associated with | ||
| the `DPMixtureModel` or `HDPMixtureModel` objects. | ||
|
|
||
| The hyperparameters for the mixture model are values that govern the prior distributions. Similar prior distributions to those selected here were used in [cite PlosComp paper and Comp Immuno Methods paper etc] and experience suggests these are appropriate for a wide variety of cytokine panels. Furthermore, examples of model parameterization can be found in the FCM documentation examples section [[link]]. |
There was a problem hiding this comment.
You forgot to fix up the [cite...] entry here, I think.
|
Generally good. Should be a quick fix to address the citation on line 303. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made the requested edits from reviewers. Please merge these changes that address the issues raised by reviewers.