Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time-of-arrival of a neutron at the detector is commonly named time-of-flight or
tof
.This name is however misleading because it is not necessarily the time the neutron spent in-flight,
since that also depends on the birth time of the neutron.
Only the arrival time is known at a neutron beamline,
and there is thus an inherent uncertainty in the birth time as neutrons can originate from any part of the pulse.
This is especially true at long-pulse neutron sources such as ESS.
We rename
tof
totoa
in this PR to remove confusion around the definition of time-of-flight.We keep the
tofs
properties andtof
coordinate, and add deprecation warnings when they are accessed.