Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wfm stitching notebook with new frame finding and time overlap removal #53

Closed
wants to merge 6 commits into from

Conversation

nvaytet
Copy link
Member

@nvaytet nvaytet commented Oct 1, 2024

  • We use the more general frame finding approach used in the DREAM choppers setup to find the individual WFM frames.
  • We also introduce removal of time overlap between frames, by gradually increasing percentile cutoffs on the tofs of consecutive frames.
  • In the process, we also added individual ids to the neutrons in a source, which are useful and used in this example.

Depends on #51

@nvaytet nvaytet changed the title Update wfm stitching notebook with new frame finding and wavelength overlap removal Update wfm stitching notebook with new frame finding and time overlap removal Oct 2, 2024
@nvaytet nvaytet marked this pull request as ready for review October 2, 2024 13:43
@nvaytet nvaytet requested a review from jokasimr October 2, 2024 13:43
@nvaytet nvaytet marked this pull request as draft October 7, 2024 10:31
@nvaytet
Copy link
Member Author

nvaytet commented Oct 7, 2024

I'm converting to a draft as I think we should go with the simpler approach of computing wavelengths using interpolation which gives wavelength as a function of time of arrival.

@nvaytet
Copy link
Member Author

nvaytet commented Oct 11, 2024

Superseded by #57

@nvaytet nvaytet closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants